fix(Notification): Removed/renamed props to adopt to UI5-Webcomponents conventions #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p, renamed 'showCloseButton' and 'hideShowMoreButton'
|
Deploy preview for ui5-webcomponents-react ready! Built with commit 66b7066 https://deploy-preview-223--ui5-webcomponents-react.netlify.com |
MarcusNotheis
requested changes
Nov 12, 2019
packages/main/src/components/Notification/Notification.test.tsx
Outdated
Show resolved
Hide resolved
packages/main/src/components/NotificationGroup/Notification.test.tsx
Outdated
Show resolved
Hide resolved
packages/main/src/components/NotificationGroup/Notification.test.tsx
Outdated
Show resolved
Hide resolved
packages/main/src/components/NotificationGroup/Notification.test.tsx
Outdated
Show resolved
Hide resolved
packages/main/src/components/NotificationGroup/Notification.test.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 74.14% 74.14%
=======================================
Files 159 159
Lines 3724 3724
Branches 670 670
=======================================
Hits 2761 2761
+ Misses 736 735 -1
- Partials 227 228 +1
Continue to review full report at Codecov.
|
MarcusNotheis
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221