Skip to content

fix(AnalyticalTable): correctly indent root level tree row #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2021
Merged

fix(AnalyticalTable): correctly indent root level tree row #1948

merged 2 commits into from
Aug 9, 2021

Conversation

@Lukas742
Copy link
Contributor

@Lukas742 Lukas742 commented Aug 9, 2021 •
edited
Loading

Fixes indentation of root level tree items and rtl

fixes #1807

@Lukas742 Lukas742 requested a review from MarcusNotheis as a code owner August 9, 2021 07:19
@coveralls
Copy link

coveralls commented Aug 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1112337337

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 79.36%
Totals Coverage Status
Change from base Build 1112336206: 0.006%
Covered Lines: 2876
Relevant Lines: 3624
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Aug 9, 2021 •
edited
Loading

Size Change: +32 B (0%)

Total Size: 214 kB

Filename Size Change
packages/main/dist/AnalyticalTable.js 25.7 kB +32 B (0%)
ℹ️ View Unchanged
Filename Size
packages/base/dist/CssSizeVariables.js 971 B
packages/base/dist/Device.js 2.92 kB
packages/base/dist/hooks.js 1.77 kB
packages/base/dist/spacing.js 1.01 kB
packages/base/dist/StyleClassHelper.js 637 B
packages/base/dist/ThemingParameters.js 3.6 kB
packages/base/dist/useConsolidatedRef.js 271 B
packages/base/dist/usePassThroughHtmlProps.js 327 B
packages/base/dist/useViewportRange.js 405 B
packages/base/dist/Utils.js 1.06 kB
packages/charts/dist/BarChart.js 4.22 kB
packages/charts/dist/BarChartPlaceholder.js 459 B
packages/charts/dist/ColumnChart.js 4.44 kB
packages/charts/dist/ColumnChartPlaceholder.js 514 B
packages/charts/dist/ColumnChartWithTrend.js 1.8 kB
packages/charts/dist/ColumnChartWithTrendPlaceholder.js 601 B
packages/charts/dist/components/ChartContainer.js 1.8 kB
packages/charts/dist/components/ChartDataLabel.js 605 B
packages/charts/dist/components/XAxisTicks.js 617 B
packages/charts/dist/components/YAxisTicks.js 514 B
packages/charts/dist/ComposedChart.js 5.17 kB
packages/charts/dist/ComposedChartPlaceholder.js 878 B
packages/charts/dist/DonutChart.js 3.25 kB
packages/charts/dist/LineChart.js 4.31 kB
packages/charts/dist/LineChartPlaceholder.js 529 B
packages/charts/dist/MicroBarChart.js 2.11 kB
packages/charts/dist/PieChart.js 3.13 kB
packages/charts/dist/PieChartPlaceholder.js 445 B
packages/charts/dist/RadarChart.js 2.39 kB
packages/charts/dist/RadialChart.js 1.44 kB
packages/charts/dist/ScatterChart.js 4.07 kB
packages/charts/dist/ScatterChartPlaceholder.js 536 B
packages/charts/dist/useLegendItemClick.js 395 B
packages/charts/dist/Utils.js 436 B
packages/main/dist/ActionSheet.js 2.58 kB
packages/main/dist/AnalyticalCard.js 869 B
packages/main/dist/AnalyticalCardHeader.js 2.52 kB
packages/main/dist/AnalyticalTableHooks.js 1.73 kB
packages/main/dist/AnalyticalTableScrollMode.js 177 B
packages/main/dist/Assets-static.js 56 B
packages/main/dist/Assets.js 49 B
packages/main/dist/assets/i18n/i18n-defaults.js 960 B
packages/main/dist/Avatar.js 555 B
packages/main/dist/AvatarColorScheme.js 269 B
packages/main/dist/AvatarGroup.js 593 B
packages/main/dist/AvatarGroupType.js 212 B
packages/main/dist/AvatarShape.js 208 B
packages/main/dist/AvatarSize.js 219 B
packages/main/dist/Badge.js 449 B
packages/main/dist/Bar.js 526 B
packages/main/dist/BarcodeScannerDialog.js 612 B
packages/main/dist/BarDesign.js 226 B
packages/main/dist/Breadcrumbs.js 597 B
packages/main/dist/BreadcrumbsDesign.js 227 B
packages/main/dist/BreadcrumbsItem.js 344 B
packages/main/dist/BreadcrumbsSeparatorStyle.js 266 B
packages/main/dist/BusyIndicator.js 524 B
packages/main/dist/BusyIndicatorSize.js 223 B
packages/main/dist/Button.js 465 B
packages/main/dist/ButtonDesign.js 254 B
packages/main/dist/Calendar.js 659 B
packages/main/dist/CalendarDate.js 332 B
packages/main/dist/CalendarSelection.js 163 B
packages/main/dist/CalendarSelectionMode.js 242 B
packages/main/dist/CalendarType.js 212 B
packages/main/dist/Card.js 508 B
packages/main/dist/CardHeader.js 465 B
packages/main/dist/Carousel.js 586 B
packages/main/dist/CarouselArrowsPlacement.js 241 B
packages/main/dist/CheckBox.js 603 B
packages/main/dist/ColorPalette.js 365 B
packages/main/dist/ColorPaletteItem.js 334 B
packages/main/dist/ColorPicker.js 364 B
packages/main/dist/ComboBox.js 565 B
packages/main/dist/ComboBoxGroupItem.js 366 B
packages/main/dist/ComboBoxItem.js 332 B
packages/main/dist/ContentDensity.js 151 B
packages/main/dist/CustomListItem.js 455 B
packages/main/dist/DatePicker.js 606 B
packages/main/dist/DateRangePicker.js 558 B
packages/main/dist/DateTimePicker.js 581 B
packages/main/dist/DeviationIndicator.js 160 B
packages/main/dist/Dialog.js 721 B
packages/main/dist/DynamicPage.js 5.31 kB
packages/main/dist/DynamicPageHeader.js 1.37 kB
packages/main/dist/DynamicPageTitle.js 2.7 kB
packages/main/dist/FCLLayout.js 280 B
packages/main/dist/FileUploader.js 683 B
packages/main/dist/FilterBar.js 8.63 kB
packages/main/dist/FilterGroupItem.js 1.53 kB
packages/main/dist/FlexBox.js 1.08 kB
packages/main/dist/FlexBoxAlignItems.js 189 B
packages/main/dist/FlexBoxDirection.js 169 B
packages/main/dist/FlexBoxJustifyContent.js 194 B
packages/main/dist/FlexBoxWrap.js 154 B
packages/main/dist/FlexibleColumnLayout.js 521 B
packages/main/dist/Form.js 2.83 kB
packages/main/dist/FormGroup.js 720 B
packages/main/dist/FormItem.js 1.55 kB
packages/main/dist/GlobalStyleClasses.js 151 B
packages/main/dist/Grid.js 2.03 kB
packages/main/dist/GridPosition.js 157 B
packages/main/dist/GroupHeaderListItem.js 378 B
packages/main/dist/GrowingMode.js 225 B
packages/main/dist/Icon.js 655 B
packages/main/dist/IllustratedMessage.js 689 B
packages/main/dist/IllustrationMessageType.js 330 B
packages/main/dist/IndicationColor.js 279 B
packages/main/dist/Input.js 832 B
packages/main/dist/InputType.js 235 B
packages/main/dist/json-imports/i18n-static.js 1.06 kB
packages/main/dist/json-imports/i18n.js 963 B
packages/main/dist/Label.js 569 B
packages/main/dist/Link.js 529 B
packages/main/dist/LinkDesign.js 224 B
packages/main/dist/List.js 777 B
packages/main/dist/ListGrowingMode.js 229 B
packages/main/dist/ListItemType.js 217 B
packages/main/dist/ListMode.js 266 B
packages/main/dist/ListSeparators.js 241 B
packages/main/dist/Loader.js 1.45 kB
packages/main/dist/LoaderType.js 152 B
packages/main/dist/MessageBox.js 2.7 kB
packages/main/dist/MessageBoxActions.js 231 B
packages/main/dist/MessageBoxTypes.js 232 B
packages/main/dist/MessageStrip.js 515 B
packages/main/dist/MessageStripDesign.js 243 B
packages/main/dist/MultiComboBox.js 714 B
packages/main/dist/MultiComboBoxItem.js 364 B
packages/main/dist/MultiInput.js 723 B
packages/main/dist/NotificationAction.js 419 B
packages/main/dist/NotificationListGroupItem.js 612 B
packages/main/dist/NotificationListItem.js 673 B
packages/main/dist/ObjectPage.js 12.2 kB
packages/main/dist/ObjectPageMode.js 159 B
packages/main/dist/ObjectPageSection.js 1.57 kB
packages/main/dist/ObjectPageSubSection.js 1.49 kB
packages/main/dist/ObjectStatus.js 1.81 kB
packages/main/dist/Option.js 368 B
packages/main/dist/Page.js 476 B
packages/main/dist/PageBackgroundDesign.js 216 B
packages/main/dist/Panel.js 487 B
packages/main/dist/PanelAccessibleRole.js 234 B
packages/main/dist/Popover.js 650 B
packages/main/dist/PopoverHorizontalAlign.js 256 B
packages/main/dist/PopoverPlacementType.js 234 B
packages/main/dist/PopoverVerticalAlign.js 248 B
packages/main/dist/Priority.js 219 B
packages/main/dist/ProductSwitch.js 374 B
packages/main/dist/ProductSwitchItem.js 421 B
packages/main/dist/ProgressIndicator.js 430 B
packages/main/dist/RadioButton.js 592 B
packages/main/dist/RangeSlider.js 502 B
packages/main/dist/RatingIndicator.js 443 B
packages/main/dist/ResponsiveGridLayout.js 1.2 kB
packages/main/dist/ResponsivePopover.js 614 B
packages/main/dist/SegmentedButton.js 475 B
packages/main/dist/SegmentedButtonItem.js 510 B
packages/main/dist/Select.js 447 B
packages/main/dist/SemanticColor.js 237 B
packages/main/dist/ShellBar.js 542 B
packages/main/dist/ShellBarItem.js 375 B
packages/main/dist/SideNavigation.js 608 B
packages/main/dist/SideNavigationItem.js 413 B
packages/main/dist/SideNavigationSubItem.js 373 B
packages/main/dist/Size.js 151 B
packages/main/dist/Slider.js 493 B
packages/main/dist/StandardListItem.js 520 B
packages/main/dist/StepInput.js 613 B
packages/main/dist/SuggestionGroupItem.js 360 B
packages/main/dist/SuggestionItem.js 430 B
packages/main/dist/Switch.js 610 B
packages/main/dist/SwitchDesign.js 208 B
packages/main/dist/Tab.js 475 B
packages/main/dist/TabContainer.js 493 B
packages/main/dist/TabLayout.js 211 B
packages/main/dist/Table.js 704 B
packages/main/dist/TableCell.js 331 B
packages/main/dist/TableColumn.js 401 B
packages/main/dist/TableGroupRow.js 325 B
packages/main/dist/TableGrowingMode.js 230 B
packages/main/dist/TableMode.js 231 B
packages/main/dist/TablePlaceholder.js 799 B
packages/main/dist/TableRow.js 359 B
packages/main/dist/TableRowType.js 207 B
packages/main/dist/TableScaleWidthMode.js 169 B
packages/main/dist/TableSelectionBehavior.js 178 B
packages/main/dist/TableSelectionMode.js 182 B
packages/main/dist/TableVisibleRowCountMode.js 189 B
packages/main/dist/TabSeparator.js 338 B
packages/main/dist/Text.js 986 B
packages/main/dist/TextAlign.js 183 B
packages/main/dist/TextArea.js 649 B
packages/main/dist/ThemeProvider.js 938 B
packages/main/dist/Themes.js 188 B
packages/main/dist/Timeline.js 600 B
packages/main/dist/TimelineItem.js 361 B
packages/main/dist/TimelineLayout.js 213 B
packages/main/dist/TimePicker.js 539 B
packages/main/dist/Title.js 392 B
packages/main/dist/TitleLevel.js 233 B
packages/main/dist/Toast.js 418 B
packages/main/dist/ToastPlacement.js 286 B
packages/main/dist/ToggleButton.js 644 B
packages/main/dist/Token.js 379 B
packages/main/dist/Toolbar.js 3.41 kB
packages/main/dist/ToolbarDesign.js 175 B
packages/main/dist/ToolbarSeparator.js 649 B
packages/main/dist/ToolbarSpacer.js 348 B
packages/main/dist/ToolbarStyle.js 153 B
packages/main/dist/Tree.js 416 B
packages/main/dist/TreeItem.js 457 B
packages/main/dist/UploadCollection.js 478 B
packages/main/dist/UploadCollectionItem.js 528 B
packages/main/dist/UploadState.js 211 B
packages/main/dist/ValueState.js 182 B
packages/main/dist/VariantManagement.js 2.08 kB
packages/main/dist/VerticalAlign.js 174 B
packages/main/dist/withWebComponent.js 1.72 kB
packages/main/dist/Wizard.js 442 B
packages/main/dist/WizardStep.js 468 B
packages/main/dist/WrappingType.js 242 B

compressed-size-action

@Lukas742 Lukas742 enabled auto-merge (squash) August 9, 2021 09:37
@Lukas742 Lukas742 merged commit efbcfc1 into main Aug 9, 2021
@Lukas742 Lukas742 deleted the fix/analytical-table-indentation branch August 9, 2021 09:45
@ui5-webcomponents-react-bot
Copy link
Collaborator

ui5-webcomponents-react-bot commented Aug 9, 2021

🎉 This PR is included in version v0.18.0 🎉

The release is available on v0.18.0

Your semantic-release bot 📦🚀

Lukas742 added a commit that referenced this pull request Aug 10, 2021
@Lukas742
fix(AnalyticalTable): correctly indent root level tree rows (#1948)
0e1aaf8
Lukas742 added a commit that referenced this pull request Aug 10, 2021
@Lukas742
feat(AnalyticalTable): cherry-pick keyboard navigation and other fixes (
e795b19 
#1958)

* fix(AnalyticalTable): correctly indent root level tree rows (#1948)

* fix(AnalyticalTable): unselect rows in single-select mode & correctly select rows with row-selector only behavior (#1951)

* feat(AnalyticalTable): add improved keyboard navigation (#1864)
@Lukas742 Lukas742 mentioned this pull request Aug 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcusNotheis MarcusNotheis MarcusNotheis approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AnalyticalTable: First level is not aligned in tree table mode

5 participants

@Lukas742 @coveralls @ui5-webcomponents-react-bot @MarcusNotheis