Skip to content

fix(ComboBox): Add missing onSelectionChange event prop #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2021
Merged

fix(ComboBox): Add missing onSelectionChange event prop #1399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5e5405
fix(ComboBox): Add missing onSelectionChange event prop
Lukas742 Mar 9, 2021
e2b2f34
Merge branch 'main' into fix/checkbox-selection-change
Lukas742 Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/main/scripts/create-web-components-wrapper.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const prettierConfig = {
};

const WEB_COMPONENTS_ROOT_DIR = path.join(PATHS.packages, 'main', 'src', 'webComponents');
const LIB_DIR = path.join(PATHS.packages, 'main', 'src', 'lib');
const DIST_DIR = path.join(PATHS.packages, 'main', 'src', 'dist');

const KNOWN_EVENTS = new Set(['click', 'input', 'submit', 'change', 'select', 'drop']);

Expand Down Expand Up @@ -1028,7 +1028,7 @@ resolvedWebComponents.forEach((componentSpec) => {
export type { ${componentSpec.module}PropTypes };`,
prettierConfig
);
fs.writeFileSync(path.join(LIB_DIR, `${componentSpec.module}.ts`), libContent);
fs.writeFileSync(path.join(DIST_DIR, `${componentSpec.module}.ts`), libContent);

// create test
if (!fs.existsSync(path.join(webComponentFolderPath, `${componentSpec.module}.test.tsx`))) {
Expand Down
6 changes: 5 additions & 1 deletion packages/main/src/webComponents/ComboBox/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ export interface ComboBoxPropTypes extends Omit<WithWebComponentPropTypes, 'onCh
* **Note:** filterValue property is updated, input is changed.
*/
onInput?: (event: CustomEvent) => void;
/**
* Fired when the selection has changed via user interaction
*/
onSelectionChange?: (event: CustomEvent<{ item: ReactNode }>) => void;
}

/**
Expand All @@ -110,7 +114,7 @@ const ComboBox: FC<ComboBoxPropTypes> = withWebComponent<ComboBoxPropTypes>(
['filter', 'filterValue', 'placeholder', 'value', 'valueState'],
['disabled', 'loading', 'readonly', 'required'],
['icon', 'valueStateMessage'],
['change', 'input']
['change', 'input', 'selection-change']
);

ComboBox.displayName = 'ComboBox';
Expand Down