Skip to content

fix(VariantManagement): disabled prop disables onClick events #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2019
Merged

fix(VariantManagement): disabled prop disables onClick events #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c90a9c3
fix(VariantManagement): disabled prop disables onClick events
Lukas742 Sep 13, 2019
5fb9f90
updated snapshots
Lukas742 Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/main/src/components/FilterBar/__snapshots__/FilterBar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports[`FilterBar Hide Filter Bar 1`] = `
class="FilterBar--filterBarHeader-"
>
<div
style="display: inline-block;"
style="pointer-events: auto; display: inline-block;"
>
<div
class="Variant-Management--VariantManagement-"
Expand Down Expand Up @@ -172,7 +172,7 @@ exports[`FilterBar Render without crashing 1`] = `
class="FilterBar--filterBarHeader-"
>
<div
style="display: inline-block;"
style="pointer-events: auto; display: inline-block;"
>
<div
class="Variant-Management--VariantManagement-"
Expand Down Expand Up @@ -325,7 +325,7 @@ exports[`FilterBar Select Filter Item 1`] = `
class="FilterBar--filterBarHeader-"
>
<div
style="display: inline-block;"
style="pointer-events: auto; display: inline-block;"
>
<div
class="Variant-Management--VariantManagement-"
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/components/VariantManagement/__snapshots__/VariantManagement.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`VariantManagement Render without crashing 1`] = `
Array [
<div
style="display: inline-block;"
style="pointer-events: auto; display: inline-block;"
>
<div
class="Variant-Management--VariantManagement-"
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/components/VariantManagement/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ const VariantManagement: FC<VariantManagementPropTypes> = forwardRef(
headerText={popupTitle}
placementType={placement}
openBy={variantManagementButton}
openByStyle={{ pointerEvents: disabled ? 'none' : 'auto' }}
footer={footerButtons}
className={className}
innerStyles={style}
Expand Down