Skip to content

Commit f30d2fc

Browse files
chore: delete deprecated FilterItem (#717)
BREAKING CHANGE: deleted deprecated component `FilterItem`, please use `FilterGroupItem` instead. The `FilterBar` is now accepting only `FilterGroupItem`s as children. Closes #646
1 parent 96c0a5a commit f30d2fc

File tree

8 files changed

+0
-200
lines changed

8 files changed

+0
-200
lines changed

packages/main/src/components/FilterBar/FilterDialog.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,15 +193,13 @@ export const FilterDialog = (props) => {
193193
const renderChildren = useCallback(() => {
194194
return children
195195
.filter((item) => {
196-
if (item.type.displayName !== 'FilterGroupItem') return true; //needed for deprecated FilterItem or custom elements
197196
return (
198197
!!item?.props &&
199198
item.props?.visible &&
200199
(item.props?.label?.toLowerCase().includes(searchString.toLowerCase()) || searchString.length === 0)
201200
);
202201
})
203202
.map((child) => {
204-
if (child.type.displayName !== 'FilterGroupItem') return child; //needed for deprecated FilterItem or custom elements
205203
const filterBarItemRef = filterBarRefs.current[child.key];
206204
let filterItemProps = {};
207205
if (filterBarItemRef) {

packages/main/src/components/FilterBar/index.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -238,12 +238,9 @@ const FilterBar: FC<FilterBarPropTypes> = forwardRef((props: FilterBarPropTypes,
238238
const childProps = { considerGroupName, inFB: true } as any;
239239
return safeChildren()
240240
.filter((item: ReactElement<any, any>) => {
241-
if (item.type.displayName !== 'FilterGroupItem') return true; // needed for deprecated FilterItem or custom elements
242-
243241
return item?.props?.visible && item.props?.visibleInFilterBar;
244242
})
245243
.map((child: ReactElement<any, any>) => {
246-
if (child.type.displayName !== 'FilterGroupItem') return child; // needed for deprecated FilterItem or custom elements
247244
if (filterContainerWidth) {
248245
childProps.style = { width: filterContainerWidth, ...child.props.style };
249246
}

packages/main/src/components/FilterItem/FilterItem.jss.ts

Lines changed: 0 additions & 20 deletions
This file was deleted.

packages/main/src/components/FilterItem/index.tsx

Lines changed: 0 additions & 159 deletions
This file was deleted.

packages/main/src/enums/FilterType.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.

packages/main/src/index.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ import { FCLLayout } from './lib/FCLLayout';
4141
import { FileUploader } from './lib/FileUploader';
4242
import { FilterBar } from './lib/FilterBar';
4343
import { FilterGroupItem } from './lib/FilterGroupItem';
44-
import { FilterItem } from './lib/FilterItem';
45-
import { FilterType } from './lib/FilterType';
4644
import { FlexBox } from './lib/FlexBox';
4745
import { FlexBoxAlignItems } from './lib/FlexBoxAlignItems';
4846
import { FlexBoxDirection } from './lib/FlexBoxDirection';
@@ -197,8 +195,6 @@ export {
197195
FileUploader,
198196
FilterBar,
199197
FilterGroupItem,
200-
FilterItem,
201-
FilterType,
202198
FlexBox,
203199
FlexBoxAlignItems,
204200
FlexBoxDirection,

packages/main/src/lib/FilterItem.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/main/src/lib/FilterType.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)