Skip to content

Commit 6f370d9

Browse files
authored
fix(AnalyticalTable - TypeScript): improve callback types (#7858)
1 parent 77f9098 commit 6f370d9

File tree

1 file changed

+7
-7
lines changed
  • packages/main/src/components/AnalyticalTable/types

1 file changed

+7
-7
lines changed

packages/main/src/components/AnalyticalTable/types/index.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -976,12 +976,12 @@ export interface AnalyticalTablePropTypes extends Omit<CommonProps, 'title'> {
976976
/**
977977
* Fired when the grouping of the rows changes.
978978
*/
979-
onGroup?: (e: CustomEvent<{ column: ColumnType; groupedColumns: string[] }>) => void;
979+
onGroup?: (e: CustomEvent<{ column: ColumnType; groupedColumns: string[]; isGrouped: boolean }>) => void;
980980
/**
981981
* Fired when a row is selected or unselected.
982982
*/
983983
onRowSelect?: (
984-
e?: CustomEvent<{
984+
e: CustomEvent<{
985985
/**
986986
* Selected row object.
987987
*
@@ -1007,11 +1007,11 @@ export interface AnalyticalTablePropTypes extends Omit<CommonProps, 'title'> {
10071007
/**
10081008
* Fired when a row is expanded or collapsed
10091009
*/
1010-
onRowExpandChange?: (e?: CustomEvent<{ row: unknown; column: unknown }>) => void;
1010+
onRowExpandChange?: (e: CustomEvent<{ row: unknown; column: unknown }>) => void;
10111011
/**
10121012
* Fired when the columns order is changed.
10131013
*/
1014-
onColumnsReorder?: (e?: CustomEvent<{ columnsNewOrder: string[]; column: unknown }>) => void;
1014+
onColumnsReorder?: (e: CustomEvent<{ columnsNewOrder: ColumnType[]; column: ColumnType }>) => void;
10151015
/**
10161016
* Fired when the `infiniteScrollThreshold` is reached.
10171017
*
@@ -1021,21 +1021,21 @@ export interface AnalyticalTablePropTypes extends Omit<CommonProps, 'title'> {
10211021
* @param {number} e.detail.rowCount - The number of rows
10221022
* @param {number} e.detail.totalRowCount - The total number of rows, including sub-rows
10231023
*/
1024-
onLoadMore?: (e?: CustomEvent<{ rowCount: number; totalRowCount: number }>) => void;
1024+
onLoadMore?: (e: CustomEvent<{ rowCount: number; totalRowCount: number }>) => void;
10251025
/**
10261026
* Fired when the body of the table is scrolled.
10271027
*
10281028
* __Note:__ This callback __must be memoized__! Since it is triggered on __every scroll event__,
10291029
* non-memoized or expensive calculations can have a __huge impact on performance__ and cause visible lag.
10301030
* Throttling or debouncing is always recommended to reduce performance overhead.
10311031
*/
1032-
onTableScroll?: (e?: CustomEvent<{ rows: Record<string, any>[]; rowElements: HTMLCollection }>) => void;
1032+
onTableScroll?: (e: CustomEvent<{ rows: Record<string, any>[]; rowElements: HTMLCollection }>) => void;
10331033
/**
10341034
* Fired when the table is resized by double-clicking the Resizer.
10351035
*
10361036
* __Note:__ Auto-resize is only available on columns that have the `autoResizable` option set to `true`.
10371037
*/
1038-
onAutoResize?: (e?: OnAutoResizeMouseEvent) => void;
1038+
onAutoResize?: (e: OnAutoResizeMouseEvent) => void;
10391039
/**
10401040
* Fired when a filter is applied to a column.
10411041
*/

0 commit comments

Comments
 (0)