Skip to content

Commit 5080316

Browse files
Lukas742MarcusNotheis
authored andcommitted
refactor(VariantManagement): removed unused prop enabled (#77)
BREAKING CHANGE Removed prop `enabled`, please use `disabled` instead. This change should not affect your applications, because `enabled` was never implemented.
1 parent e127293 commit 5080316

File tree

4 files changed

+7
-9
lines changed

4 files changed

+7
-9
lines changed

packages/main/__karma_snapshots__/DayPicker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
```
66
<ThemeProvider withToastContainer={false}>
7-
<JssProvider generateId={[Function]} id={{...}}>
7+
<JssProvider generateId={[Function]}>
88
<ThemeProvider theme={{...}}>
99
<DayPicker>
1010
<ui5-daypicker class="" />

packages/main/__karma_snapshots__/FilterBar.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<FilterBar renderSearch={[Function: renderSearch]} renderVariants={[Function: renderVariants]} displayOnly={true} innerRef={{...}} classes={{...}} theme={{...}}>
1111
<div className="FilterBar-outerContainer---">
1212
<div className="FilterBar-filterBarHeader---">
13-
<Variant Management variantItems={{...}} enabled={true} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
13+
<Variant Management variantItems={{...}} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
1414
<Popover open={false} onAfterOpen={[Function]} headerText="Variants" placementType="Bottom" openBy={{...}} footer={{...}} className={[undefined]} innerStyles={[undefined]} tooltip={[undefined]} initialFocus={{...}} horizontalAlign="Center" verticalAlign="Center">
1515
<div style={{...}} onClick={[Function]}>
1616
<div className="Variant-Management--VariantManagement---">
@@ -125,7 +125,7 @@
125125
<FilterBar renderVariants={[Function: renderVariants]} displayOnly={true} innerRef={{...}} classes={{...}} theme={{...}}>
126126
<div className="FilterBar-outerContainer---">
127127
<div className="FilterBar-filterBarHeader---">
128-
<Variant Management variantItems={{...}} enabled={true} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
128+
<Variant Management variantItems={{...}} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
129129
<Popover open={false} onAfterOpen={[Function]} headerText="Variants" placementType="Bottom" openBy={{...}} footer={{...}} className={[undefined]} innerStyles={[undefined]} tooltip={[undefined]} initialFocus={{...}} horizontalAlign="Center" verticalAlign="Center">
130130
<div style={{...}} onClick={[Function]}>
131131
<div className="Variant-Management--VariantManagement---">
@@ -249,7 +249,7 @@
249249
<FilterBar renderVariants={[Function: renderVariants]} displayOnly={true} innerRef={{...}} classes={{...}} theme={{...}}>
250250
<div className="FilterBar-outerContainer---">
251251
<div className="FilterBar-filterBarHeader---">
252-
<Variant Management variantItems={{...}} enabled={true} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
252+
<Variant Management variantItems={{...}} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
253253
<Popover open={false} onAfterOpen={[Function]} headerText="Variants" placementType="Bottom" openBy={{...}} footer={{...}} className={[undefined]} innerStyles={[undefined]} tooltip={[undefined]} initialFocus={{...}} horizontalAlign="Center" verticalAlign="Center">
254254
<div style={{...}} onClick={[Function]}>
255255
<div className="Variant-Management--VariantManagement---">

packages/main/__karma_snapshots__/VariantManagement.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<ThemeProvider withToastContainer={false}>
77
<JssProvider generateId={[Function]}>
88
<ThemeProvider theme={{...}}>
9-
<Variant Management variantItems={{...}} enabled={true} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
9+
<Variant Management variantItems={{...}} popupTitle="Variants" initialSelectedKey={{...}} onSelect={[Function: onSelect]} closeOnItemSelect={true} placement="Bottom" level="H4" disabled={false}>
1010
<Popover open={false} onAfterOpen={[Function]} headerText="Variants" placementType="Bottom" openBy={{...}} footer={{...}} className={[undefined]} innerStyles={[undefined]} tooltip={[undefined]} initialFocus={{...}} horizontalAlign="Center" verticalAlign="Center">
1111
<div style={{...}} onClick={[Function]}>
1212
<div className="Variant-Management--VariantManagement---">
@@ -29,8 +29,8 @@
2929
</Button>
3030
<WithWebComponent(List) onItemClick={[Function]} mode="SingleSelect" headerText="" footerText="" noDataText="" separators="All">
3131
<ui5-list mode="SingleSelect" header-text="" footer-text="" no-data-text="" separators="All" class="">
32-
<StandardListItem style={{...}} data-key="1" type="Active" selected={false} infoState="None">
33-
<ui5-li style={{...}} data-key="1" type="Active" info-state="None" class="">
32+
<StandardListItem style={{...}} data-key="1" type="Active" selected={true} infoState="None">
33+
<ui5-li selected={true} style={{...}} data-key="1" type="Active" info-state="None" class="">
3434
Variant 1
3535
</ui5-li>
3636
</StandardListItem>

packages/main/src/components/VariantManagement/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export interface VariantItem {
2020
}
2121

2222
export interface VariantManagementPropTypes extends CommonProps {
23-
enabled?: boolean;
2423
placement?: PlacementType;
2524
popupTitle?: string;
2625
initialSelectedKey?: string;
@@ -185,7 +184,6 @@ const VariantManagement: FC<VariantManagementPropTypes> = forwardRef(
185184
);
186185

187186
VariantManagement.defaultProps = {
188-
enabled: true,
189187
popupTitle: 'Variants',
190188
initialSelectedKey: null,
191189
onSelect: () => {},

0 commit comments

Comments
 (0)