Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly name functions in services and rebind them to twisted names #38

Open
1wilkens opened this issue Nov 6, 2019 · 0 comments
Open

Comments

@1wilkens
Copy link
Member

1wilkens commented Nov 6, 2019

twisted sometimes requires unintuitive method names for services such as AvatarId among others. Currently most services name their functions directly like this. We should properly name these functions according to their use and rebind them under the required name.

Example from TelnetService:

# Twisted requires these exact method names on the class so we rebind them
connectionMade = on_new_connection
telnet_User = on_username
telnet_Password = on_password

@1wilkens 1wilkens changed the title [Enhancement] Properly name functions in services and rebind them to twisted names Properly name functions in services and rebind them to twisted names Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant