Skip to content

Conversation

@mdko
Copy link
Contributor

@mdko mdko commented Aug 4, 2021

In this commit, I updated blif import to be a little more general, but in so doing, introduced a place where n (nand) nets are created. The n net is a non-primitive in PyRTL, and should only be introduced via a call to nand_synth(), and so issues come up if you import a BLIF that generates a n, and then try to export it to Verilog, for example, where checks are made for unsupported nets.

This PR just converts any n seen during BLIF import into a combination of ~ and &.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2021

Codecov Report

Merging #401 (750cc70) into development (2d9ab35) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #401   +/-   ##
============================================
  Coverage        90.71%   90.71%           
============================================
  Files               24       24           
  Lines             5989     5989           
============================================
  Hits              5433     5433           
  Misses             556      556           
Impacted Files Coverage Δ
pyrtl/importexport.py 85.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9ab35...750cc70. Read the comment docs.

@mdko mdko merged commit e15cf0d into UCSBarchlab:development Aug 4, 2021
@mdko mdko deleted the blif-import-update branch August 4, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants