-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add polyfill for TimeSpan.FromMilliseconds(long, [long])
#43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds polyfills for the TimeSpan.FromMilliseconds method overloads introduced in .NET 9.0 and .NET 10.0. The .NET 9.0 version adds support for specifying both milliseconds and microseconds parameters, while the .NET 10.0 version provides a long-based overload that delegates to the two-parameter version.
Key Changes
- Added polyfill for
TimeSpan.FromMilliseconds(long milliseconds, long microseconds)in Net90 - Added polyfill for
TimeSpan.FromMilliseconds(long milliseconds)in Net100 - Added basic test coverage for both implementations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| PolyShim/Net90/TimeSpan.cs | Implements two-parameter FromMilliseconds polyfill for .NET 9.0 |
| PolyShim/Net100/TimeSpan.cs | Implements single-parameter FromMilliseconds polyfill for .NET 10.0 |
| PolyShim.Tests/Net90/TimeSpanTests.cs | Adds test for two-parameter overload |
| PolyShim.Tests/Net100/TimeSpanTests.cs | Adds test for single-parameter overload |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.