Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 16, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 16, 2025 21:24
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 16, 2025
Copilot finished reviewing on behalf of Tyrrrz November 16, 2025 21:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds polyfills for the TimeSpan.FromMilliseconds method overloads introduced in .NET 9.0 and .NET 10.0. The .NET 9.0 version adds support for specifying both milliseconds and microseconds parameters, while the .NET 10.0 version provides a long-based overload that delegates to the two-parameter version.

Key Changes

  • Added polyfill for TimeSpan.FromMilliseconds(long milliseconds, long microseconds) in Net90
  • Added polyfill for TimeSpan.FromMilliseconds(long milliseconds) in Net100
  • Added basic test coverage for both implementations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
PolyShim/Net90/TimeSpan.cs Implements two-parameter FromMilliseconds polyfill for .NET 9.0
PolyShim/Net100/TimeSpan.cs Implements single-parameter FromMilliseconds polyfill for .NET 10.0
PolyShim.Tests/Net90/TimeSpanTests.cs Adds test for two-parameter overload
PolyShim.Tests/Net100/TimeSpanTests.cs Adds test for single-parameter overload

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Tyrrrz and others added 2 commits November 16, 2025 23:29
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Tyrrrz Tyrrrz requested a review from Copilot November 16, 2025 21:30
Copilot finished reviewing on behalf of Tyrrrz November 16, 2025 21:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit e6a209d into master Nov 16, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the timespan-from-ms branch November 16, 2025 21:34
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (80bd7dd) to head (776660f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #43   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants