Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 16, 2025

Pull request #17 (@bfriesen) introduced the <autogenerated/> tags at the beginning of each polyfill code file. Unfortunately, it also directs CSharpier to ignore these files during development. Reverting that PR for now until we find a way that satisfies both use cases.

Copilot AI review requested due to automatic review settings November 16, 2025 17:49
@Tyrrrz Tyrrrz added the bug Something isn't working label Nov 16, 2025
Copilot finished reviewing on behalf of Tyrrrz November 16, 2025 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the <auto-generated/> comment tags from all polyfill code files to enable CSharpier formatting during development. The change reverts PR #17 which had added these tags to instruct analyzers to skip the files, but inadvertently prevented CSharpier from formatting them.

Key changes:

  • Removed 3-line auto-generated comment blocks from the beginning of all polyfill files
  • Applied CSharpier formatting improvements including better line wrapping, consistent trailing commas, and improved spacing
  • No functional code changes

Reviewed Changes

Copilot reviewed 107 out of 107 changed files in this pull request and generated no comments.

Show a summary per file
File Description
PolyShim/PolyfillExtensions.cs Removed auto-generated comment block
PolyShim/NetCore30/*.cs (14 files) Removed auto-generated comments and applied formatting improvements
PolyShim/NetCore21/*.cs (8 files) Removed auto-generated comments and applied formatting improvements
PolyShim/NetCore20/*.cs (17 files) Removed auto-generated comments and applied formatting improvements
PolyShim/NetCore10/*.cs (14 files) Removed auto-generated comments and applied formatting improvements
PolyShim/Net90/*.cs (6 files) Removed auto-generated comments and applied formatting improvements
PolyShim/Net80/CancellationTokenSource.cs Removed auto-generated comment block
PolyShim/Net70/*.cs (10 files) Removed auto-generated comments and applied formatting improvements
PolyShim/Net60/*.cs (13 files) Removed auto-generated comments and applied formatting improvements
PolyShim/Net50/*.cs (20 files) Removed auto-generated comments and applied formatting improvements
PolyShim/NamespaceDummies.cs Removed auto-generated comment block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 2667445 into master Nov 16, 2025
11 checks passed
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (804837c) to head (fb3762c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #42   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants