Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for a cwd setting #17

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Added support for a cwd setting #17

merged 1 commit into from
Mar 30, 2018

Conversation

fabiospampinato
Copy link
Contributor

Fixes #12

@Tyriar
Copy link
Owner

Tyriar commented Mar 30, 2018

Thanks @fabiospampinato, sorry about the delay

@Tyriar Tyriar merged commit 547115e into Tyriar:master Mar 30, 2018
@Tyriar
Copy link
Owner

Tyriar commented Mar 30, 2018

@fabiospampinato does this work for you? Testing it out with:

"shellLauncher.shells.osx": [
    {
      "shell": "/bin/bash",
      "label": "bash",
      "cwd": "/home/daimms/dev"
    }
]

I'm seeing a chdir error in the terminal and then this:

screen shot 2018-03-30 at 8 24 57 am

@fabiospampinato
Copy link
Contributor Author

It wasn't working for me either beucase of #18.

I think you're getting that error because /home/daimms/dev doesn't exists, should we check for that?

@Tyriar
Copy link
Owner

Tyriar commented Mar 30, 2018

I think you're getting that error because /home/daimms/dev doesn't exists

Oh yeah, I'm on my mac not Linux box, haha. It couldn't hurt to show a nicer error message.

@fabiospampinato
Copy link
Contributor Author

It couldn't hurt to show a nicer error message.

Perhaps this check should be added in VSC itself? 🤔

@Tyriar
Copy link
Owner

Tyriar commented Apr 2, 2018

microsoft/vscode#17450 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants