Skip to content

Fix strictmode #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Chemaclass merged 4 commits into from
Jul 12, 2024
Merged

Fix strictmode #285

Chemaclass merged 4 commits into from
Jul 12, 2024

Conversation

@Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Jul 12, 2024

📚 Description

Closes: #283 | Follow up after: #241

🔖 Changes

  • Existence of optional functions is tested explicitly before attempting to execute them. This has the side benefit of ensuring that an external program with the right name (e.g. set_up) will not be run instead.

Kudos to @djpohly (#239)

✅ To-do list

  • I updated the CHANGELOG.md to reflect the new feature or fix

@Chemaclass Chemaclass added the bug Something isn't working label Jul 12, 2024
@Chemaclass Chemaclass self-assigned this Jul 12, 2024
@Chemaclass Chemaclass merged commit 93f5b97 into main Jul 12, 2024
@Chemaclass Chemaclass deleted the fix/283-strictmode branch July 12, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabriziofs fabriziofs fabriziofs approved these changes

@cmayo cmayo Awaiting requested review from cmayo

@khru khru Awaiting requested review from khru

@JesusValeraDev JesusValeraDev Awaiting requested review from JesusValeraDev

@antonio-gg-dev antonio-gg-dev Awaiting requested review from antonio-gg-dev

Assignees

@Chemaclass Chemaclass

Labels

bug Something isn't working

Projects

bashunit
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix strictmode

3 participants

@Chemaclass @fabriziofs