Add assert_line_count
#259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 17, 2024
| if [ -z "$actual" ]; then | ||
| local actual_line_count=0 | ||
| else | ||
| local actual_line_count=$(echo "$actual" | wc -l | tr -d '[:blank:]') |
Contributor
Author
There was a problem hiding this comment.
on my macos, wc -l returns a number prepended by whitespaces. therefore I used tr to strip them
Chemaclass
requested review from
Chemaclass,
JesusValeraDev,
antonio-gg-dev,
cmayo,
fabriziofs and
khru
Chemaclass
reviewed
Jun 17, 2024
Member
Chemaclass
left a comment
Chemaclass
left a comment
There was a problem hiding this comment.
Very cool! Just some minor comments
Chemaclass
reviewed
Jun 17, 2024
Co-authored-by: Jose Maria Valera Reales <chemaclass@outlook.es>
JesusValeraDev
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Implement new
assert_line_countassertion function.refs #257
🔖 Changes
assert_line_count✅ To-do list
CHANGELOG.mdto reflect the new feature or fix