Support for intersection type#482
Conversation
This commit introduces the support for intersection types. Type name identifiers are added as a model property to make them available to the themes.
|
|
||
| /** | ||
| * The type name identifier. | ||
| */ |
There was a problem hiding this comment.
What do you think we should do here? I'm happy to accept the fix in a future PR. Just let me know what you think is needed to fix this!
blakeembrey
left a comment
blakeembrey
left a comment
There was a problem hiding this comment.
This LGTM, I'll wait to find out what you think we should do about the typo 😄
|
It just continues the discussion on #146. There's the argument not do change anything before 0.4 as it will break everyones code that relies on typedoc. Now we have 0.5.x and just my two cents is, we should correct this (= every occurrence of "instrinct") to "intrinsic" - either with 0.6 or just now. I think it is not to late. Typedoc is in a relatively early state and everyone should be able to handle the "breaking change" with a simple replace-in-all-files action. Certainly it will be better than living with this pretty ugly typo for the rest of our lives ;) |
|
I'm definitely happy to have it fixed and I would just bump the minor and document the occurance. Thanks. |
2 participants
This PR introduces the support for intersection types (microsoft/TypeScript#3622).
I also added the type name identifiers ('void', 'reference', 'union' etc.) as a property to the type model to access them within themes (see TypeStrong/typedoc-default-themes#45).