change value to pass as an argument (for --prefer-ts-exts) #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
approved these changes
Aug 17, 2019
src/index.ts
Outdated
| @@ -401,7 +401,7 @@ export function register (opts: Options = {}): Register { | |||
| const register: Register = { cwd, compile, getTypeInfo, extensions, ts } | |||
|
|
|||
| // Register the extensions. | |||
| registerExtensions(opts, extensions, ignore, register, originalJsHandler) | |||
| registerExtensions(options, extensions, ignore, register, originalJsHandler) | |||
There was a problem hiding this comment.
Can we pass through only options.preferTsExts, I think that's the only thing used.
There was a problem hiding this comment.
Right, I'll fix it.
|
@blakeembrey If this commit ( 405dcf6 ) is OK, I would be very happy if you could merge it. |
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--prefer-ts-extsoption ( #837 ) seemed to work for CLI arguments but not for environment variables.There are values that merge environment variables and CLI arguments (index.ts#L197), but
--prefer-ts-extsprocessing seems to use only the values received by CLI.