Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt switch from nyc to c8 #1816

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

attempt switch from nyc to c8 #1816

wants to merge 2 commits into from

Conversation

cspotcode
Copy link
Collaborator

I've done a bunch of nyc support hacks in our tests, and yet there are still weird issues.

I'm hopeful that switching to c8 avoids all that.

add helper scripts to dev against node nightly
@cspotcode cspotcode marked this pull request as ready for review June 26, 2022 22:08
@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #1816 (c090710) into main (97f9afd) will increase coverage by 5.40%.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/bin-cwd.ts 100.00% <0.00%> (ø)
src/bin-esm.ts 100.00% <0.00%> (ø)
src/bin-script.ts 100.00% <0.00%> (ø)
dist-raw/runmain-hack.js 100.00% <0.00%> (ø)
src/child/argv-payload.ts 100.00% <0.00%> (ø)
dist-raw/node-nativemodule.js 100.00% <0.00%> (ø)
dist-raw/node-internal-constants.js 100.00% <0.00%> (ø)
dist-raw/node-internal-modules-cjs-helpers.js 100.00% <0.00%> (ø)
register/transpile-only.js 0.00% <0.00%> (ø)
register/files.js 0.00% <0.00%> (ø)
... and 36 more

@cspotcode cspotcode marked this pull request as draft July 17, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant