Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow json modules to be resolved in Node >=17.5.0 without flag #1665

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

Jamesernator
Copy link
Contributor

Closes #1661.

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1665 (2e2d44b) into main (89bde51) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2e2d44b differs from pull request most recent head 4516ad2. Consider uploading reports for the commit 4516ad2 to get more accurate results

Impacted Files Coverage Δ
dist-raw/node-esm-default-get-format.js 80.55% <100.00%> (+0.55%) ⬆️

Copy link
Collaborator

@cspotcode cspotcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@cspotcode cspotcode modified the milestones: 10.6.0, 10.7.0 Mar 1, 2022
@cspotcode
Copy link
Collaborator

I had to bump the release of 10.6.0 to today to unblock users of TS 4.6.0, so I've scheduled this to be included in 10.7.0 which I'll publish tomorrow.

@cspotcode cspotcode merged commit 20cbbf5 into TypeStrong:main Mar 2, 2022
@cspotcode
Copy link
Collaborator

10.7.0 is published, including this change. Thanks again.

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 8, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-node](https://typestrong.org/ts-node) ([source](https://github.com/TypeStrong/ts-node)) | devDependencies | minor | [`10.6.0` -> `10.7.0`](https://renovatebot.com/diffs/npm/ts-node/10.6.0/10.7.0) |

---

### Release Notes

<details>
<summary>TypeStrong/ts-node</summary>

### [`v10.7.0`](https://github.com/TypeStrong/ts-node/releases/v10.7.0)

[Compare Source](TypeStrong/ts-node@v10.6.0...v10.7.0)

Questions about this release? Ask in the official discussion thread: [#&#8203;1680](TypeStrong/ts-node#1680)

**Added**

-   Adds `--esm` flag, option, and `ts-node-esm` binary ([#&#8203;1258](TypeStrong/ts-node#1258), [#&#8203;1655](TypeStrong/ts-node#1655))
    -   Enables full `esm` support; no need for `--loader` nor `NODE_OPTIONS`
    -   Use shebang `#!/usr/bin/env ts-node-esm`, run `ts-node --esm`, or add to your tsconfig.json: `"ts-node": {"esm": true}`

**Changed**

-   Unflag ESM json modules on node >=17.5.0 ([#&#8203;1661](TypeStrong/ts-node#1661), [#&#8203;1665](TypeStrong/ts-node#1665)) [@&#8203;Jamesernator](https://github.com/Jamesernator)
    -   no longer requires `--experimental-json-modules`
-   Lazy-load dependencies to improve startup responsiveness. ([#&#8203;1676](TypeStrong/ts-node#1676))

**Fixed**

-   Fixed bug where "compiler", "transpiler", and swc backend would not resolve relative to the tsconfig.json that declared them ([#&#8203;1662](TypeStrong/ts-node#1662), [#&#8203;1655](TypeStrong/ts-node#1655))
    -   Enables reusable tsconfig.json shared via node module to include necessary dependencies

https://github.com/TypeStrong/ts-node/milestone/11

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1200
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Node 17.5.0] JSON support in ESM no longer requires --experimental-json-modules
2 participants