-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Target ES2021 mapping in transpilers/swc #1521
Conversation
I was getting error: `jsc.target should be es5 or upper to use getter / setter` and after investigation I've isolated issue and here is the "fix"
Linking to #1510 since we may need to apply the same concept to |
Codecov Report
|
Thanks for investigating and sending a fix. I want to throw together a regression test. What did you do to cause the error? And did it terminate the node process with a non-zero exit code, or did it log a warning? This info will help write a quick test. |
in my tsconfig.json I have: {
"compilerOptions": {
"target": "ES2021",
...
},
"ts-node": {
"require": ["tsconfig-paths/register"],
"files": true,
"transpileOnly": true,
"transpiler": "ts-node/transpilers/swc-experimental"
}
} then I was requiring a module from local module (I have monorepos setup).
so that when this module is required build js and d.ts files are used. as target for my tsconfig was es2021 in compiled js the use of property
and the error is here:
|
I'm sure we would get same issue with |
Thanks for including all the details. At a glance, I could not find a list of every single |
Does this look like a complete list? |
looks like it |
I was getting error:
jsc.target should be es5 or upper to use getter / setter
and after investigation I've isolated issue and here is the "fix"