Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to turn off sourceMap #796

Open
staeke opened this issue Mar 6, 2019 · 6 comments
Open

Ability to turn off sourceMap #796

staeke opened this issue Mar 6, 2019 · 6 comments
Labels
needs more info you can do this Good candidate for a pull request.

Comments

@staeke
Copy link

staeke commented Mar 6, 2019

There is no way to turn off source maps as of now. See e.g. #27

Source maps are not always desired, and can make debugging a lot harder - see e.g. facebook/create-react-app#1557

Feature request: allow turning off. Suggested way by respecting tsconfig.json

@blakeembrey
Copy link
Member

What's the use case or issue here? You linked to unrelated things.

@staeke
Copy link
Author

staeke commented Mar 6, 2019

@blakeembrey they're related....let me clarify:

#27 is about how default settings for source maps override any user settings. The person creating the other ticket considered it a bug, but someone stated that sourceMaps should always override user settings anyhow. I think that's bad, but understand that changes elsewhere in code is also needed.

The create-react-app link is about why people would want to turn off source maps

@blakeembrey
Copy link
Member

@staeke You're always welcome to submit a PR that'll add a flag to disable this behavior.

My question is because it sounds like this is a feature request, but there hasn't been anyone with an issue that warrants this feature. But again, if you'd like to add it, I won't block on that.

@rubenlg
Copy link

rubenlg commented Dec 12, 2021

Looking forward to this feature. When running ts-node inside electron, source-map-support blows up every time any module attempts to read the stack of an exception, with the following message:

Uncaught RangeError: WebAssembly.Compile is disallowed on the main thread, if the buffer size is larger than 4KB. Use WebAssembly.compile, or compile on a worker thread.

@cspotcode
Copy link
Collaborator

I recommend checking out #1533 and submitting a pull request. It should solve your problem. #1533 has a low level of effort required for implementation, and I'm happy to answer any questions in the comments for #1533.

@rubenlg
Copy link

rubenlg commented Dec 13, 2021

I dropped the require that you pointed out in #1533 altogether, and that fixes the issue.
I suspect the right solution in my case would be to fix the interoperability between source-map-support and electron in the source-map-support module instead, but as a quick workaround, patching ts-node did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info you can do this Good candidate for a pull request.
Projects
None yet
Development

No branches or pull requests

4 participants