Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add config file as build dependency #1611

Conversation

alexander-akait
Copy link
Contributor

@alexander-akait alexander-akait commented May 16, 2023

Make configuration more DX, we already known typescript configuration, so let's add it as a build dependency and not need provide to add this in build dependency like here #1332

@johnnyreilly
Copy link
Member

Builds passed - do you want to update the package.json / changelog.md?

@alexander-akait
Copy link
Contributor Author

@johnnyreilly If need I can do, just don't know contirbution process, can you describe?

@johnnyreilly
Copy link
Member

Change the version in the package.json to represent a new version - I'd say this is a patch rather than anything else.

The changelog.md is hopefully self explanatory - put a version entry in, linking back to this PR. Nothing more

@alexander-akait
Copy link
Contributor Author

Change the version in the package.json to represent a new version - I'd say this is a patch rather than anything else.

The changelog.md is hopefully self explanatory - put a version entry in, linking back to this PR. Nothing more

Okay, I will do it, just thought that the release process is separate from the fixes/features, because we have 5f28651 and I don't know what I should put in Changelog

@johnnyreilly
Copy link
Member

So the changelog addition would probably be:

## 9.4.3
* [fix: add config file as build dependency](https://github.com/TypeStrong/ts-loader/pull/1611) - thanks @alexander-akait 

@alexander-akait
Copy link
Contributor Author

@johnnyreilly Done 👍

@johnnyreilly johnnyreilly merged commit cf5326d into TypeStrong:main May 23, 2023
@johnnyreilly
Copy link
Member

@alexander-akait alexander-akait deleted the feat-configfile-as-build-dependecy branch May 23, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants