Fixed generating cache for loading options to handle objects #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks potentially like a reasonable approach (though I think you mentioned that more need to be done on the related issue). I think this has broken some of the comparison tests - please could you take a look? |
|
@johnnyreilly I think it should be better now. Let me what if you want to change the check somehow. |
timocov
commented
May 13, 2021
test/comparison-tests/errorFormatter/expectedOutput-4.2/output.txt
Outdated
Show resolved
Hide resolved
|
@johnnyreilly now it should be fine I guess 🙂 |
|
Do you want to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1316