-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #1287 to v8 #1291
Backport #1287 to v8 #1291
Conversation
…ves when using compiler default functions" TypeStrong#1287 to v8
It is yes - I've never tried publishing from a branch that isn't main using the GitHub Actions workflow. Wonder if it works.... |
Failing comparison tests - you may want to regenerate the output for the failing tests. See https://github.com/TypeStrong/ts-loader/tree/main/test/comparison-tests#regenerating-test-data |
I think you may have regenerated all of the test output, rather than just the failing test cases? |
Yeah - I think there's something wrong with your backport |
This reverts commit f04c5cf.
@johnnyreilly gonna need some help please. I don't know what I'm looking at. |
So to regenerate the failing test I did this: |
Yes, I ran exactly that (although I also ran "instance" since that one was also listed as failing, from my reading). |
I did it in the context of |
…WatchApi --save-output
|
good, right? |
Yup - good. This is where we find out if the automation works for the non- |
Backport "Use caches for module resolution and type reference directives when using compiler default functions" #1287 to v8
@johnnyreilly is this the right branch for any version 8 patches?
CC @sheetalkamat