webpack exit code is equal to 0, if typescript build fails

[marcelkottmann]

When the build fails (i.e. at least one typescript compile error occured), the ts-loader emits an incomplete javascript file and does not propagate the build failure to webpack. When using webpack with the --bail command line option an compile error, should result in an webpack exit code not equal to zero.

Is there another way or option to check if a compile error occured.

[mpseidel]

+1 - this would be really helpful

@PePe79 theoretically you could use the --noEmitOnError typescript option to get an exit code > 0 but then you only get something like this as an error message ModuleBuildError: Module build failed: Error: Typescript emitted no output for .../file.ts so none of the helpful ts compiler errors.

[marcelkottmann]

yes, i tried this already before, but this error message is not really useful.

https://github.com/denvned/webpack-typescript does fail with exit code > 0 on compile error with webpack command line option --bail

But this loader has other issues, so that's not an alternative for us and i would like to go on with ts-loader. But this bug is a blocker for our automated builds.

[jbrantly]

Yea, definitely know the need is there. Have you tried noEmitOnError (even though there are possibly issues with that - #91)?

[jbrantly]

Wow. I didn't get a lot of sleep and missed your comment on noEmitOnError. Sorry.

[denvned]

@PePe79, I would be happy to resolve any issues you have with webpack-typescript: https://github.com/denvned/webpack-typescript/issues

[MarkusKramer]

+1 would be really great if this was fixed. as incomplete error messages are obviously a big problem.

[EvAlex]

👍 unbeleivable! That's a blocker issue for using with build server!

[EvAlex]

@denvned, your loader has the same issue

[EvAlex]

Oh yeah, I've managed to fix it. I will create Pull Request and attach explaination there in 6-8 hours.

[raybooysen]

or @EvAlex @denvned @jbrantly combine to have a single loader, so we don't have all these disparate loaders. :)

[jbrantly]

Always open to PRs. FWIW, I think the correct solution to this is to fix #91 to be more useful and then combine that with --bail for the webpack exit code, but since I haven't actually dug in and tried it yet I don't know if there are problems with that approach.

[vladimir-rovensky]

FWIW until this is fixed you can use something like webpack-fail-plugin to make your build fail on error.