files from node_modules getting resloved despite being in .eslintignore

[olessavluk]

Hi 👋

After updating to 6.2.6 which includes #602 I've got this error eslint/eslint#14533. My config is:

eslint: {
    files: ['**/*.{js,jsx,ts,tsx}'],
},

But I also have node_modules ignored and when running from CLI yarn eslint --fix '**/*.{js,jsx,ts,tsx}' it works just fine.

Do you think it can be fixed? Or maybe I can specify this blob differently to not include node_modules in the first place?

[ratherblue]

Having this issue as well. Just tried upgrading @nuxt/typescript-build from ^2.0.3 to ^2.1.0 and our build is broken with this same error after fork-ts-checker-webpack-plugin changed from 5.1.0 to 6.1.1. We have node_modules ignored everywhere but it still tries to check the folder.

[ratherblue]

Alright, narrowed it down. Calling engine.isPathIgnored(path) calls this code in ESLint:

isPathIgnored(filePath) {
    const {
        configArrayFactory,
        defaultIgnores,
        options: { cwd, ignore }
    } = internalSlotsMap.get(this);
    const absolutePath = path.resolve(cwd, filePath);

    if (ignore) {
        const config = configArrayFactory
            .getConfigArrayForFile(absolutePath)
            .extractConfig(absolutePath);
        const ignores = config.ignores || defaultIgnores;
        return ignores(absolutePath);
    }
    return defaultIgnores(absolutePath);
}

This calls ESLint's configArrayFactory which tries to load configuration for that file. If you try to run isPathIgnored on a file in node_modules containing an ESLint config you don't have installed locally the check will fail. So for example in my project when it tries to check if /app/node_modules/@babel/preset-modules/lib/index.js is ignored (which it is), it still loads the config for that project from the package.json file which contains this:

"eslintConfig": {
  "extends": "developit",
  "rules": {
    "no-console": 0,
    "new-cap": 0
  }
},

I don't have the developit configuration, so now my build fails.

In #602 the check for !engine.isPathIgnored(path) was moved from only checking changed files to all files that fall under the files glob match. This typically includes files inside node_modules unless your files glob is specific enough to not include any node_modules folders.

Until this bug is fixed it you have to either:

A) Downgrade to a version that doesn't include the changes from #602

or

B) Change your files glob to be very specific to avoid the node_modules directory entirely. Ignoring node_modules does not fix this issue.

[piotr-oles]

@ratherblue thanks for debugging it. Feel free to create a PR. If you don't have time, I will do it when I find a moment :)

[ratherblue]

I can try to take a stab tomorrow morning 👍.

…

On Mon, May 10, 2021 at 11:37 PM Piotr Oleś ***@***.***> wrote: @ratherblue <https://github.com/ratherblue> thanks for debugging it. Feel free to create a PR. If you don't have time, I will do it when I find a moment :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#606 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHSRGDADBXLF7ZSJSKJI3DTNDGDNANCNFSM44KH5OJQ> .

[piotr-oles]

🎉 This issue has been resolved in version 6.2.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[piotr-oles]

🎉 This issue has been resolved in version 7.0.0-alpha.15 🎉

The release is available on:

• npm package (@alpha dist-tag)
• GitHub release

Your semantic-release bot 📦🚀