chore: min node version, dep updates and ts-loader in test matrix

Author: SimonSchick

.travis.yml

@@ -7,6 +7,7 @@ install:
  - yarn add $WEBPACK $TSLOADER $VUELOADER -D
  - yarn lint
 env:
+ - WEBPACK=webpack@^4.0.0 TSLOADER=ts-loader@^5.0.0 VUELOADER=vue-loader@^15.2.4
  - WEBPACK=webpack@^4.0.0 TSLOADER=ts-loader@^4.3.0 VUELOADER=vue-loader@^15.2.4
  - WEBPACK=webpack@^3.10.0 TSLOADER=ts-loader@^3.4.0 VUELOADER=vue-loader@^13.5.0
  - WEBPACK=webpack@^2.7.0 TSLOADER=ts-loader@^3.4.0 VUELOADER=vue-loader@^13.5.0

CHANGELOG.md

@@ -1,3 +1,14 @@
+## v0.5.0
+ * Removed unused dependency `resolve`.
+ * Replace `lodash` usage with native calls.
+ * Test against ts-loader v5
+ * **Breaking changes**:
+   * Dropped support for node v6, minimum is now v8.9
+ * **Internal**:
+   * Enable all strict type checks
+   * Update dev dependencies
+
+
 ## v0.4.15
 
 * [Add `tslintAutoFix` option to be passed on to tslint to auto format typescript files](https://github.com/Realytics/fork-ts-checker-webpack-plugin/pull/174) (#174)

package.json

@@ -3,14 +3,14 @@
   "version": "0.4.15",
   "description": "Runs typescript type checker and linter on separate process.",
   "main": "lib/index.js",
-  "types": "lib/types/index.d.ts",
+  "types": "lib/index.d.ts",
   "files": [
     "lib"
   ],
   "scripts": {
     "build": "tsc --version && tsc --project \"./src\"",
     "test:unit": "mocha -R spec ./test/unit --exit",
-    "test:integration": "mocha -R spec ./test/integration --exit",
+    "test:integration": "mocha -R spec ./test/integration --exit && rimraf tmp",
     "test": "npm run build && npm run test:unit && npm run test:integration",
     "test:watch": "mocha -R spec --watch ./test/unit",
     "test:coverage": "rimraf coverage && istanbul cover -root lib --include-all-sources mocha -- -R spec ./test/unit ./test/integration",
@@ -37,7 +37,7 @@
     "webpack-plugin"
   ],
   "engines": {
-    "node": ">=6.11.5"
+    "node": ">=8.9.0"
   },
   "author": "Piotr Oleś <piotrek.oles@gmail.com>",
   "contributors": [
@@ -53,23 +53,23 @@
     "@types/chokidar": "^1.7.5",
     "@types/micromatch": "^3.1.0",
     "@types/minimatch": "^3.0.1",
-    "@types/node": "^8.0.26",
-    "@types/webpack": "^4.4.9",
-    "chai": "^3.5.0",
-    "css-loader": "^0.28.7",
+    "@types/node": "^8.10.38",
+    "@types/webpack": "^4.4.19",
+    "chai": "^4.2.0",
+    "css-loader": "0.28.11",
     "eslint": "^5.7.0",
-    "husky": "^1.1.2",
+    "husky": "^1.1.4",
     "istanbul": "^0.4.5",
-    "lint-staged": "^7.3.0",
+    "lint-staged": "^8.0.5",
     "mocha": "^5.2.0",
     "mock-fs": "^4.3.0",
-    "mock-require": "^2.0.2",
+    "mock-require": "^3.0.2",
     "prettier": "^1.14.3",
     "rimraf": "^2.5.4",
-    "sinon": "^2.3.1",
-    "ts-loader": "4.3.0",
+    "sinon": "^7.1.1",
+    "ts-loader": "^5.3.0",
     "tslint": "^5.11.0",
-    "tslint-config-prettier": "^1.15.0",
+    "tslint-config-prettier": "^1.16.0",
     "typescript": "^3.0.1",
     "vue": "^2.5.16",
     "vue-class-component": "^6.1.1",

src/FilesRegister.ts

@@ -1,16 +1,17 @@
 import * as ts from 'typescript';
+import { RuleFailure } from 'tslint';
 
 export interface DataShape {
   source?: ts.SourceFile;
   linted: boolean;
-  lints: any[];
+  lints: RuleFailure[];
 }
 
 export class FilesRegister {
   files: { [filePath: string]: { mtime?: number; data: DataShape } };
-  dataFactory: (_data?: any) => DataShape; // It doesn't seem that the _data parameter is ever used?
+  dataFactory: (_data?: DataShape) => DataShape; // It doesn't seem that the _data parameter is ever used?
 
-  constructor(dataFactory: (_data?: any) => DataShape) {
+  constructor(dataFactory: (_data?: DataShape) => DataShape) {
     this.files = {};
     this.dataFactory = dataFactory;
   }

src/WorkResult.ts

@@ -1,19 +1,20 @@
 import { Message } from './Message';
 
 export class WorkResult {
-  workResult: {};
-  workDomain: any[];
+  workResult: {
+    [key: string]: Message;
+  } = {};
+  workDomain: number[];
 
-  constructor(workDomain: any[]) {
-    this.workResult = {};
+  constructor(workDomain: number[]) {
     this.workDomain = workDomain;
   }
 
   supports(workName: number) {
     return -1 !== this.workDomain.indexOf(workName);
   }
 
-  set(workName: number, result: any) {
+  set(workName: number, result: Message) {
     if (!this.supports(workName)) {
       throw new Error(
         'Cannot set result - work "' + workName + '" is not supported.'

src/tsconfig.json

@@ -1,16 +1,15 @@
 {
   "compilerOptions": {
-    "target": "es6",
+    "target": "es2017",
     "noImplicitReturns": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "suppressImplicitAnyIndexErrors": true,
     "strict": true,
-    "lib": ["es6", "dom"],
+    "lib": ["es2017", "dom"],
     "module": "commonjs",
     "moduleResolution": "node",
     "declaration": true,
-    "outDir": "../lib",
-    "declarationDir": "../lib/types"
+    "outDir": "../lib"
   }
 }

test/integration/index.spec.js

@@ -75,7 +75,7 @@ describe('[INTEGRATION] index', function() {
   it('should allow to pass no options', function() {
     expect(function() {
       new ForkTsCheckerWebpackPlugin();
-    }).to.not.throw.error;
+    }).to.not.throw();
   });
 
   it('should detect paths', function() {
@@ -299,15 +299,15 @@ describe('[INTEGRATION] index', function() {
       createCompiler({
         tsconfig: '/some/path/that/not/exists/tsconfig.json'
       });
-    }).to.throw.error;
+    }).to.throw();
   });
 
   it('should throw error if config container wrong tslint.json path', function() {
     expect(function() {
       createCompiler({
         tslint: '/some/path/that/not/exists/tslint.json'
       });
-    }).to.throw.error;
+    }).to.throw();
   });
 
   it('should find the same errors on multi-process mode', function(callback) {
@@ -345,7 +345,7 @@ describe('[INTEGRATION] index', function() {
   it('should detect tslint path for true option', function() {
     expect(function() {
       createCompiler({ tslint: true });
-    }).to.not.throw.error;
+    }).to.not.throw();
   });
 
   it('should allow delaying service-start', function(callback) {

test/integration/project/src/lintingError1.ts

@@ -0,0 +1 @@
+function someFunctionName(param1,param2){return param1+param2};

test/unit/CancellationToken.spec.js

@@ -72,7 +72,7 @@ describe('[UNIT] CancellationToken', function() {
     var tokenB = new CancellationToken('rgeer#R23r$#T$3t#$t43', true);
     expect(function() {
       tokenB.throwIfCancellationRequested();
-    }).to.throw(ts.OperationCanceledException);
+    }).to.throw().instanceOf(ts.OperationCanceledException);
   });
 
   it('should write file in filesystem on requestCancellation', function() {

test/unit/NormalizedMessage.spec.js

@@ -44,7 +44,7 @@ describe('[UNIT] NormalizedMessage', function() {
   it('should serialize and create from json', function() {
     var json = diagnosticMessage.toJSON();
 
-    expect(json).to.be.object;
+    expect(json).to.be.an('object');
 
     var jsonMessage = NormalizedMessage.createFromJSON(json);