WI #1990 Fix type comparison in procedure call checker (#1993)

fm-117 · web-flow · commit a41d44b3d542 · 2021-07-01T09:10:22.000+02:00
diff --git a/TypeCobol/Compiler/Diagnostics/TypeCobolChecker.cs b/TypeCobol/Compiler/Diagnostics/TypeCobolChecker.cs
@@ -377,8 +377,8 @@ private static void Check(Node node, [NotNull] FunctionCall call, [NotNull] IPro
                             TypeDefinition calleeType = expected.TypeDefinition;
                             if (callerType != null && calleeType != null)
                             {
-                                //Compare references of TypeDefinition
-                                if (callerType != calleeType)
+                                //Compare TypeDefinitions
+                                if (!callerType.Equals(calleeType))
                                 {
                                     var m = string.Format(
                                         "Function '{0}' expected parameter '{1}' of type {2} and received '{3}' of type {4} ",

Original file line number	Diff line number	Diff line change
`@@ -377,8 +377,8 @@ private static void Check(Node node, [NotNull] FunctionCall call, [NotNull] IPro`
`377`	`377`	`TypeDefinition calleeType = expected.TypeDefinition;`
`378`	`378`	`if (callerType != null && calleeType != null)`
`379`	`379`	`{`
`380`		`- //Compare references of TypeDefinition`
`381`		`- if (callerType != calleeType)`
	`380`	`+ //Compare TypeDefinitions`
	`381`	`+ if (!callerType.Equals(calleeType))`
`382`	`382`	`{`
`383`	`383`	`var m = string.Format(`
`384`	`384`	`"Function '{0}' expected parameter '{1}' of type {2} and received '{3}' of type {4} ",`