WI #1267 Use Warning instead of Error for premature PERFORM exit

Author: fm-117

TypeCobol.Analysis.Test/BasicCfgInstrs/IX105A.diag

@@ -12,38 +12,38 @@ Line 421[12,47] <37, Warning, General> - Warning: "end-if" is missing
 Line 423[12,46] <37, Warning, General> - Warning: "end-if" is missing
 Line 436[12,47] <37, Warning, General> - Warning: "end-if" is missing
 Line 437[12,42] <37, Warning, General> - Warning: "end-if" is missing
-Line 455[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 485, column 15 prevents this PERFORM statement to reach its exit.
-Line 456[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 478, column 15 prevents this PERFORM statement to reach its exit.
-Line 457[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 485, column 15 prevents this PERFORM statement to reach its exit.
-Line 458[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 478, column 15 prevents this PERFORM statement to reach its exit.
-Line 459[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 485, column 15 prevents this PERFORM statement to reach its exit.
-Line 460[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 478, column 15 prevents this PERFORM statement to reach its exit.
+Line 455[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 485, column 15 prevents this PERFORM statement to reach its exit.
+Line 456[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 478, column 15 prevents this PERFORM statement to reach its exit.
+Line 457[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 485, column 15 prevents this PERFORM statement to reach its exit.
+Line 458[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 478, column 15 prevents this PERFORM statement to reach its exit.
+Line 459[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 485, column 15 prevents this PERFORM statement to reach its exit.
+Line 460[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-01-FAIL' located at line 478, column 15 prevents this PERFORM statement to reach its exit.
 Line 461[12,37] <37, Warning, General> - Warning: "end-if" is missing
 Line 507[12,40] <37, Warning, General> - Warning: "end-if" is missing
 Line 511[12,33] <37, Warning, General> - Warning: "end-if" is missing
 Line 546[12,42] <37, Warning, General> - Warning: "end-if" is missing
 Line 573[12,46] <37, Warning, General> - Warning: "end-if" is missing
 Line 578[12,36] <37, Warning, General> - Warning: "end-if" is missing
-Line 600[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 630, column 15 prevents this PERFORM statement to reach its exit.
-Line 601[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 623, column 15 prevents this PERFORM statement to reach its exit.
-Line 602[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 630, column 15 prevents this PERFORM statement to reach its exit.
-Line 603[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 623, column 15 prevents this PERFORM statement to reach its exit.
-Line 604[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 630, column 15 prevents this PERFORM statement to reach its exit.
-Line 605[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 623, column 15 prevents this PERFORM statement to reach its exit.
+Line 600[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 630, column 15 prevents this PERFORM statement to reach its exit.
+Line 601[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 623, column 15 prevents this PERFORM statement to reach its exit.
+Line 602[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 630, column 15 prevents this PERFORM statement to reach its exit.
+Line 603[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 623, column 15 prevents this PERFORM statement to reach its exit.
+Line 604[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 630, column 15 prevents this PERFORM statement to reach its exit.
+Line 605[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-02-FAIL' located at line 623, column 15 prevents this PERFORM statement to reach its exit.
 Line 606[12,37] <37, Warning, General> - Warning: "end-if" is missing
 Line 651[12,40] <37, Warning, General> - Warning: "end-if" is missing
 Line 655[12,33] <37, Warning, General> - Warning: "end-if" is missing
 Line 686[12,42] <37, Warning, General> - Warning: "end-if" is missing
 Line 711[12,42] <37, Warning, General> - Warning: "end-if" is missing
 Line 716[15,39] <37, Warning, General> - Warning: "end-if" is missing
-Line 738[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 770, column 15 prevents this PERFORM statement to reach its exit.
-Line 739[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 763, column 15 prevents this PERFORM statement to reach its exit.
-Line 740[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 770, column 15 prevents this PERFORM statement to reach its exit.
-Line 741[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 763, column 15 prevents this PERFORM statement to reach its exit.
-Line 742[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 770, column 15 prevents this PERFORM statement to reach its exit.
-Line 743[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 763, column 15 prevents this PERFORM statement to reach its exit.
-Line 744[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 770, column 15 prevents this PERFORM statement to reach its exit.
-Line 745[12,12] <30, Error, Semantics> - Semantic error: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 763, column 15 prevents this PERFORM statement to reach its exit.
+Line 738[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 770, column 15 prevents this PERFORM statement to reach its exit.
+Line 739[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 763, column 15 prevents this PERFORM statement to reach its exit.
+Line 740[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 770, column 15 prevents this PERFORM statement to reach its exit.
+Line 741[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 763, column 15 prevents this PERFORM statement to reach its exit.
+Line 742[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 770, column 15 prevents this PERFORM statement to reach its exit.
+Line 743[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 763, column 15 prevents this PERFORM statement to reach its exit.
+Line 744[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 770, column 15 prevents this PERFORM statement to reach its exit.
+Line 745[12,12] <37, Warning, General> - Warning: Statement '       GO TO WRITE-TEST-GF-03-FAIL' located at line 763, column 15 prevents this PERFORM statement to reach its exit.
 Line 746[12,37] <37, Warning, General> - Warning: "end-if" is missing
 Line 794[12,39] <37, Warning, General> - Warning: "end-if" is missing
 Line 801[12,42] <37, Warning, General> - Warning: "end-if" is missing

TypeCobol.Analysis.Test/BasicCfgInstrs/PerformGoesOutOfbounds0.diag

@@ -1,2 +1,2 @@
 --- Diagnostics ---
-Line 4[12,12] <30, Error, Semantics> - Semantic error: Statement '    go to b' located at line 10, column 12 prevents this PERFORM statement to reach its exit.
+Line 4[12,12] <37, Warning, General> - Warning: Statement '    go to b' located at line 10, column 12 prevents this PERFORM statement to reach its exit.

TypeCobol.Analysis.Test/BasicCfgInstrs/SG102A.diag

@@ -24,23 +24,23 @@ Line 380[12,16] <37, Warning, General> - Warning: ALTER should not be used
 Line 397[12,16] <37, Warning, General> - Warning: ALTER should not be used
 Line 407[12,40] <37, Warning, General> - Warning: "end-if" is missing
 Line 411[12,16] <37, Warning, General> - Warning: ALTER should not be used
-Line 426[12,12] <30, Error, Semantics> - Semantic error: Statement '    GO TO TEST-5A' located at line 597, column 12 prevents this PERFORM statement to reach its exit.
+Line 426[12,12] <37, Warning, General> - Warning: Statement '    GO TO TEST-5A' located at line 597, column 12 prevents this PERFORM statement to reach its exit.
 Line 427[12,33] <37, Warning, General> - Warning: "end-if" is missing
 Line 448[12,16] <37, Warning, General> - Warning: ALTER should not be used
 Line 451[12,33] <37, Warning, General> - Warning: "end-if" is missing
 Line 470[12,16] <37, Warning, General> - Warning: ALTER should not be used
 Line 485[12,16] <37, Warning, General> - Warning: ALTER should not be used
-Line 495[12,12] <30, Error, Semantics> - Semantic error: Statement '        GO TO TEST-3-WRITE' located at line 516, column 16 prevents this PERFORM statement to reach its exit.
-Line 495[12,12] <30, Error, Semantics> - Semantic error: Statement '    GO TO TEST-3-WRITE' located at line 520, column 12 prevents this PERFORM statement to reach its exit.
+Line 495[12,12] <37, Warning, General> - Warning: Statement '        GO TO TEST-3-WRITE' located at line 516, column 16 prevents this PERFORM statement to reach its exit.
+Line 495[12,12] <37, Warning, General> - Warning: Statement '    GO TO TEST-3-WRITE' located at line 520, column 12 prevents this PERFORM statement to reach its exit.
 Line 496[12,16] <37, Warning, General> - Warning: ALTER should not be used
 Line 497[12,16] <37, Warning, General> - Warning: ALTER should not be used
-Line 498[12,12] <30, Error, Semantics> - Semantic error: Statement '        GO TO TEST-3-WRITE' located at line 516, column 16 prevents this PERFORM statement to reach its exit.
-Line 498[12,12] <30, Error, Semantics> - Semantic error: Statement '    GO TO TEST-3-WRITE' located at line 520, column 12 prevents this PERFORM statement to reach its exit.
+Line 498[12,12] <37, Warning, General> - Warning: Statement '        GO TO TEST-3-WRITE' located at line 516, column 16 prevents this PERFORM statement to reach its exit.
+Line 498[12,12] <37, Warning, General> - Warning: Statement '    GO TO TEST-3-WRITE' located at line 520, column 12 prevents this PERFORM statement to reach its exit.
 Line 514[12,33] <37, Warning, General> - Warning: "end-if" is missing
 Line 526[12,33] <37, Warning, General> - Warning: "end-if" is missing
 Line 539[12,33] <37, Warning, General> - Warning: "end-if" is missing
-Line 559[12,12] <30, Error, Semantics> - Semantic error: Statement '    GO TO SEG-TEST-2' located at line 369, column 12 prevents this PERFORM statement to reach its exit.
-Line 559[12,12] <30, Error, Semantics> - Semantic error: Statement '    GO TO SEG-TEST8' located at line 372, column 12 prevents this PERFORM statement to reach its exit.
+Line 559[12,12] <37, Warning, General> - Warning: Statement '    GO TO SEG-TEST-2' located at line 369, column 12 prevents this PERFORM statement to reach its exit.
+Line 559[12,12] <37, Warning, General> - Warning: Statement '    GO TO SEG-TEST8' located at line 372, column 12 prevents this PERFORM statement to reach its exit.
 Line 560[12,33] <37, Warning, General> - Warning: "end-if" is missing
 Line 576[12,16] <37, Warning, General> - Warning: ALTER should not be used
 Line 578[12,33] <37, Warning, General> - Warning: "end-if" is missing

TypeCobol.Analysis/Cfg/ControlFlowGraphBuilder.cs

@@ -1063,7 +1063,7 @@ private void RelocateBasicBlockForNodeGroupGraph(PerformProcedure p, BasicBlockF
                     string offendingStatement = offendingInstruction.CodeElement.SourceText;
                     int offendingLine = offendingInstruction.CodeElement.Line;
                     int offendingColumn = offendingInstruction.CodeElement.Column;
-                    Diagnostic d = new Diagnostic(MessageCode.SemanticTCErrorInParser,
+                    Diagnostic d = new Diagnostic(MessageCode.Warning,
                         p.CodeElement.Column,
                         p.CodeElement.Column,
                         p.CodeElement.Line,