feat: Selectable non-editable text in blocks without inline content #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Sep 18, 2024
packages/core/src/extensions/FullySelectedNode/FullySelectedNodeExtension.ts
Outdated
Show resolved
Hide resolved
packages/core/src/extensions/FullySelectedNode/FullySelectedNodeExtension.ts
Outdated
Show resolved
Hide resolved
packages/core/src/extensions/FullySelectedNode/FullySelectedNodeExtension.ts
Outdated
Show resolved
Hide resolved
matthewlipski
commented
Sep 18, 2024
- Fixed copying when whole node is selected - Added formatting toolbar controller fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to have blocks without inline content which contain selectable, non-editable text. Currently, you cannot select text while the block is selected, and selecting text while a different block is selected in the editor leads to a mismatch in editor & DOM selections. You can toggle this functionality using the
canSelectTextentry in a block config.