Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-2821] Include storage configuration in debug log #3609

Open
mjpieters opened this issue Jul 1, 2021 · 2 comments
Open

[TT-2821] Include storage configuration in debug log #3609

mjpieters opened this issue Jul 1, 2021 · 2 comments

Comments

@mjpieters
Copy link

Is your feature request related to a problem? Please describe.
We had a really hard time debugging our Redis connection problems, caused by a stray newline in the Tyk helm charts. The problem was made all the harder because Tyk does not show you what configuration it thinks it has when attempting to connect.

Describe the solution you'd like
When setting the log level to DEBUG, include the connection strings used to connect to other services. These should make it much, much easier to debug Redis or other storage connectivity issues.

Describe alternatives you've considered
Tracing the GO redis library to see what it tried to connect to. Not really feasible.

Additional context
Adding validation to the storage config options could help here too; newlines or backslashes are invalid characters in both ip addresses and hostnames, after all.

@christtyk
Copy link
Contributor

I see the benefit of this for sure, I'll add the request to our product backlog for review

@christtyk christtyk changed the title Include storage configuration in debug log [TT-2821] Include storage configuration in debug log Jul 2, 2021
@letzya
Copy link
Contributor

letzya commented Jul 18, 2021

I'm Ya'ara, the DX architect in Tyk. Thank you for taking the time to log in this suggestion! Adding more info the logged message as well as validation will definitely improve engineer's life! Improving logs is definitely under my radar ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants