Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1525]Invalid user input leads to non critical 'error' log messages #3440

Open
p4k03n4t0r opened this issue Jan 11, 2021 · 2 comments
Open

Comments

@p4k03n4t0r
Copy link

Is your feature request related to a problem? Please describe.
The Tyk API Gateway (and Pump) logs messages including a log level (debug, info, warning, error). Recently we had a production issue after which we decided to add alerting based on the warning and error log level, but this is currently difficult. Wrong user input, for example invalid HMAC authentication, also leads to a error level log message. This way it's hard to decide whether the error level log line is actually an error we will have to act on or it's invalid user input we can ignore.

Describe the solution you'd like
Review the log messages written when the user does a request and change log level depending on whether something is actually broken.

Describe alternatives you've considered
A filter based on the content of the log message. This is a valid solution, we would have to find out which 'error' log messages can be ignored.

Additional context
The ProcessRequest method contains quite some of these 'fake' error log messages.

@buger buger added the zendesk label Feb 4, 2021
@christtyk christtyk changed the title Invalid user input leads to non critical 'error' log messages [TT-1525]Invalid user input leads to non critical 'error' log messages Feb 5, 2021
@Moses-oyedeji
Copy link

@p4k03n4t0r Thanks for contacting Tyk!
We apologize for the delayed response. The issue is currently being reviewed and we will keep you updated as soon as we can

@christtyk
Copy link
Contributor

This is quite low priority for us as there are workarounds available

A filter based on the content of the log message. This is a valid solution, we would have to find out which 'error' log messages can be ignored.

Would it help if we provide those error messages in the meantime? We'll keep this open anyway and consider it when we're looking at stories around our logging output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants