Prior should use PriorContext
#2170
Conversation
| model, | ||
| VarInfo(), | ||
| SamplingContext( | ||
| rng, DynamicPPL.SampleFromPrior(), DynamicPPL.PriorContext() |
There was a problem hiding this comment.
Should PriorContext() just be the default leaf context for SampleFromPrior in DynamicPPL?
There was a problem hiding this comment.
Ideally yes, but I don't think that's going to work atm because SampleFromPrior is used in too many different contexts as just "do a first sample" or "sample but also compute logjoint" or "don't sample, just evaluate the model for these parameters because I've set the delete flag to false"...
There was a problem hiding this comment.
I see, makes sense. Maybe we should rethink the design of SampleFromPrior/SampleUniform but that's not for this PR 🙂
There was a problem hiding this comment.
Indeed! This is related to TuringLang/DynamicPPL.jl#573
Pull Request Test Coverage Report for Build 7829993171
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2170 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 22
Lines 1386 1385 -1
======================================
+ Misses 1386 1385 -1 ☔ View full report in Codecov by Sentry. |
The
Priorsampler should use thePriorContextwhen sampling, notDefaultContext.This fixes #2169.