Skip to content

Commit 905f7fa

Browse files
authored
Test on 1.12 (#2707)
Now that Libtask works on 1.12, I think we can and should run CI on it. Mooncake can be disabled for the time being (it will still be tested in on 1.10).
1 parent bfa61d8 commit 905f7fa

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

.github/workflows/Tests.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,23 +35,20 @@ jobs:
3535
- name: "everything else"
3636
args: "--skip mcmc/gibbs.jl mcmc/Inference.jl ad.jl"
3737
runner:
38-
# TODO(mhauru) All the ones below that run on 1.11 should actually be run on 1.
39-
# The current setup is a temporary arrangement to deal with issues where Mooncake
40-
# and Libtask are broken on 1.12.
4138
# Default
42-
- version: '1.11'
39+
- version: '1'
4340
os: ubuntu-latest
4441
num_threads: 1
4542
# Multithreaded
46-
- version: '1.11'
43+
- version: '1'
4744
os: ubuntu-latest
4845
num_threads: 2
4946
# Windows
50-
- version: '1.11'
47+
- version: '1'
5148
os: windows-latest
5249
num_threads: 1
5350
# macOS
54-
- version: '1.11'
51+
- version: '1'
5552
os: macos-latest
5653
num_threads: 1
5754
# Minimum supported Julia version

test/ad.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ using ..Models: gdemo_default
1111
import ForwardDiff, ReverseDiff
1212

1313
# Skip Mooncake on 1.12 as it is not compatible yet
14-
const INCLUDE_MOONCAKE = VERSION >= v"1.12"
14+
const INCLUDE_MOONCAKE = VERSION < v"1.12"
1515
if INCLUDE_MOONCAKE
1616
import Pkg
1717
Pkg.add("Mooncake")

0 commit comments

Comments
 (0)