issue 737 and issue 789

[mosesmakola]

Closes #737 closes #789

[github-actions]

Benchmark Report for Commit b5f3345

Computer Information

Julia Version 1.11.5
Commit 760b2e5b739 (2025-04-14 06:53 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.6 |                 1.5 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                743.6 |                35.8 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                368.9 |                56.8 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1295.1 |                26.7 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3303.8 |                24.4 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1512.3 |                28.2 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                984.7 |                 5.1 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5519.4 |                 4.2 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1033.8 |                 8.8 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              62264.0 |                 3.7 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8872.8 |                 9.8 |
|               Dynamic |        10 |    mooncake |             typed |   true |                156.3 |                10.9 |
|              Submodel |         1 |    mooncake |             typed |   true |                 13.5 |                 6.4 |
|                   LDA |        12 | reversediff |             typed |   true |                468.0 |                 4.8 |

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (b4ee208) to head (b5f3345).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files          36       36           
  Lines        3965     3965           
=======================================
  Hits         3290     3290           
  Misses        675      675           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coveralls]

Pull Request Test Coverage Report for Build 16165535432

Details

• 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-49.0%) to 34.13%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/test_utils/models.jl	0	3	0.0%

Totals
Change from base Build 16115950849:	-49.0%
Covered Lines:	1342
Relevant Lines:	3932

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 16165535432

Details

• 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-49.0%) to 34.13%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/test_utils/models.jl	0	3	0.0%

Totals
Change from base Build 16115950849:	-49.0%
Covered Lines:	1342
Relevant Lines:	3932

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 16165535432

Details

• 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.7%) to 82.461%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/test_utils/models.jl	0	3	0.0%

Totals
Change from base Build 16115950849:	-0.7%
Covered Lines:	3263
Relevant Lines:	3957

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 16172887634

Details

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• 22 unchanged lines in 4 files lost coverage.
• Overall coverage remained the same at 83.144%

---

Files with Coverage Reduction	New Missed Lines	%
src/model.jl	1	85.83%
src/simple_varinfo.jl	5	75.72%
src/varinfo.jl	6	83.81%
src/threadsafe.jl	10	60.55%

Totals
Change from base Build 16172348055:	0.0%
Covered Lines:	3290
Relevant Lines:	3957

---

💛 - Coveralls

[penelopeysm]

@mosesmakola @mhauru I checked (#978) and the same crash is happening on main, so it's unrelated to this PR. My guess is that it has to do with new or updated dependencies.

[github-actions]

DynamicPPL.jl documentation for PR #977 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR977/

[mhauru]

Looks good, except maybe update a comment to match the new code.

[mhauru]

Thanks!

[penelopeysm]

I think it might only be maintainers who can merge, so I'll go ahead and do it:)

[mosesmakola]

I think it might only be maintainers who can merge, so I'll go ahead and do it:)

Thank you Penny!