Remove `resume_from` and `default_chain_type` #1061

penelopeysm · 2025-09-30T17:20:41Z

Removes resume_from=chn, replaces with initial_state=loadstate(chn).

Also removes default_chain_type. The reason why I want to do this is because it's one step towards removing Sampler. The replacement for this is to specify a default chain type in Turing rather than in DynamicPPL. I'll do that in a separate PR. (Notice that the default chain type is MCMCChains.Chains, but MCMCChains isn't a dep of DynamicPPL. So it just makes more sense to define this in Turing anyway.)

Closes TuringLang/Turing.jl#2675
Closes TuringLang/Turing.jl#2171
Closes #1049

github-actions · 2025-09-30T17:35:14Z

DynamicPPL.jl documentation for PR #1061 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1061/

codecov · 2025-09-30T17:44:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.38%. Comparing base (08212a2) to head (c672e3a).
⚠️ Report is 1 commits behind head on breaking.

Additional details and impacted files

@@             Coverage Diff              @@
##           breaking    #1061      +/-   ##
============================================
- Coverage     82.39%   82.38%   -0.01%     
============================================
  Files            42       42              
  Lines          3818     3816       -2     
============================================
- Hits           3146     3144       -2     
  Misses          672      672

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sunxd3

looks good

one tiny concern is whether this really closes #1049: I assume
https://github.com/TuringLang/DynamicPPL.jl/blob/c672e3adecf6e6409decd55bd1cdad90631c65ed/ext/DynamicPPLMCMCChainsExt.jl#L15C12-L15C37 does the right things for different kind of chains, but I thought it's worth mentioning.

penelopeysm · 2025-10-01T11:27:24Z

Thanks @sunxd3! Yeah, that's fair. loadstate only works directly if the saved chain 'matches' the resuming chain in terms of the number of chains. My current thinking is that it's OK to not extend the interface, and instead document the format that it returns / the format that the next chain expects so that users can manipulate it themselves into the right format if needed - do you think that'd be alright? The documentation in this PR TuringLang/docs#654 :)

penelopeysm · 2025-10-02T14:21:03Z

Docs are now live here https://turinglang.org/docs/usage/sampling-options/#saving-and-resuming-sampling

sunxd3 · 2025-10-05T09:45:27Z

@penelopeysm sorry for missing this -- looks good! thanks

* Bump minor version * bump benchmarks compat * add a skeletal changelog * `InitContext`, part 3 - Introduce `InitContext` (#981) * Implement InitContext * Fix loading order of modules; move `prefix(::Model)` to model.jl * Add tests for InitContext behaviour * inline `rand(::Distributions.Uniform)` Note that, apart from being simpler code, Distributions.Uniform also doesn't allow the lower and upper bounds to be exactly equal (but we might like to keep that option open in DynamicPPL, e.g. if the user wants to initialise all values to the same value in linked space). * Document * Add a test to check that `init!!` doesn't change linking * Fix `push!` for VarNamedVector This should have been changed in #940, but slipped through as the file wasn't listed as one of the changed files. * Add some line breaks Co-authored-by: Markus Hauru <markus@mhauru.org> * Add the option of no fallback for ParamsInit * Improve docstrings * typo * `p.default` -> `p.fallback` * Rename `{Prior,Uniform,Params}Init` -> `InitFrom{Prior,Uniform,Params}` --------- Co-authored-by: Markus Hauru <markus@mhauru.org> * use `varname_leaves` from AbstractPPL instead (#1030) * use `varname_leaves` from AbstractPPL instead * add changelog entry * fix import * tidy occurrences of varname_leaves as well (#1031) * `InitContext`, part 4 - Use `init!!` to replace `evaluate_and_sample!!`, `predict`, `returned`, and `initialize_values` (#984) * Replace `evaluate_and_sample!!` -> `init!!` * Use `ParamsInit` for `predict`; remove `setval_and_resample!` and friends * Use `init!!` for initialisation * Paper over the `Sampling->Init` context stack (pending removal of SamplingContext) * Remove SamplingContext from JETExt to avoid triggering `Sampling->Init` pathway * Remove `predict` on vector of VarInfo * Fix some tests * Remove duplicated test * Simplify context testing * Rename FooInit -> InitFromFoo * Fix JETExt * Fix JETExt properly * Fix tests * Improve comments * Remove duplicated tests * Docstring improvements Co-authored-by: Markus Hauru <markus@mhauru.org> * Concretise `chain_sample_to_varname_dict` using chain value type * Clarify testset name * Re-add comment that shouldn't have vanished * Fix stale Requires dep * Fix default_varinfo/initialisation for odd models * Add comment to src/sampler.jl Co-authored-by: Markus Hauru <markus@mhauru.org> --------- Co-authored-by: Markus Hauru <markus@mhauru.org> * `InitContext`, part 5 - Remove `SamplingContext`, `SampleFrom{Prior,Uniform}`, `{tilde_,}assume` (#985) * Remove `SamplingContext` for good * Remove `tilde_assume` as well * Split up tilde_observe!! for Distribution / Submodel * Tidy up tilde-pipeline methods and docstrings * Fix tests * fix ambiguity * Add changelog * Update HISTORY.md Co-authored-by: Markus Hauru <markus@mhauru.org> --------- Co-authored-by: Markus Hauru <markus@mhauru.org> * fix missing import * Shuffle context code around and remove dead code (#1050) * Delete the `"del"` flag (#1058) * Delete del * Fix a typo * Add HISTORY entry about del * Fixes for Turing 0.41 (#1057) * setleafcontext(model, ctx) and various other fixes * fix a bug * Add warning for `initial_parameters=...` * Remove `resume_from` and `default_chain_type` (#1061) * Remove resume_from * Format * Fix test * remove initial_params warning * Allow more flexible `initial_params` (#1064) * Enable NamedTuple/Dict initialisation * Add more tests * fix include_all kwarg for predict, improve perf (#1068) * Fix `include_all` for predict * Fix include_all for predict, some perf improvements * Replace `Metadata.flags` with `Metadata.trans` (#1060) * Replace Medata.flags with Metadata.trans * Fix a bug * Fix a typo * Fix two bugs * Rename trans to is_transformed * Rename islinked to is_transformed, remove duplication * Change pointwise_logdensities default key type to VarName (#1071) * Change pointwise_logdensities default key type to VarName * Fix a doctest * Fix DynamicPPL / MCMCChains methods (#1076) * Reimplement pointwise_logdensities (almost completely) * Move logjoint, logprior, ... as well * Fix imports, etc * Remove tests that are failing (yes I learnt this from Claude) * Changelog * logpdf * fix docstrings * allow dict output * changelog * fix some comments * fix tests * Fix more imports * Remove stray n Co-authored-by: Markus Hauru <markus@mhauru.org> * Expand `logprior`, `loglikelihood`, and `logjoint` docstrings --------- Co-authored-by: Markus Hauru <markus@mhauru.org> * Remove `Sampler` and its interface (#1037) * Remove `Sampler` and `initialstep` * Actually just remove the entire file * forgot one function * Move sampling test utils to Turing as well * Update changelog to correctly reflect changes * [skip ci] Make changelog headings more consistent --------- Co-authored-by: Markus Hauru <markus@mhauru.org>

github-actions bot assigned penelopeysm Sep 30, 2025

penelopeysm changed the title ~~Remove resume_from~~ Remove resume_from and default_chain_type Sep 30, 2025

Remove resume_from

1742b9b

penelopeysm force-pushed the py/no-resume-from branch from c0201f5 to 1742b9b Compare September 30, 2025 17:24

Format

765c7ee

penelopeysm requested a review from sunxd3 September 30, 2025 17:26

Fix test

c672e3a

sunxd3 approved these changes Oct 1, 2025

View reviewed changes

penelopeysm merged commit 7abd5fb into breaking Oct 2, 2025
20 of 21 checks passed

penelopeysm deleted the py/no-resume-from branch October 2, 2025 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove `resume_from` and `default_chain_type` #1061

Remove `resume_from` and `default_chain_type` #1061

Uh oh!

penelopeysm commented Sep 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

codecov bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

sunxd3 left a comment

Uh oh!

penelopeysm commented Oct 1, 2025 •

edited

Loading

Uh oh!

penelopeysm commented Oct 2, 2025

Uh oh!

Uh oh!

sunxd3 commented Oct 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove resume_from and default_chain_type #1061

Remove resume_from and default_chain_type #1061

Uh oh!

Conversation

penelopeysm commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

codecov bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sunxd3 left a comment

Choose a reason for hiding this comment

Uh oh!

penelopeysm commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

penelopeysm commented Oct 2, 2025

Uh oh!

Uh oh!

sunxd3 commented Oct 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove `resume_from` and `default_chain_type` #1061

Remove `resume_from` and `default_chain_type` #1061

penelopeysm commented Sep 30, 2025 •

edited

Loading

codecov bot commented Sep 30, 2025 •

edited

Loading

penelopeysm commented Oct 1, 2025 •

edited

Loading