Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BetaPrime distribution has broken tests with the recent release of Distributions. #196

Closed
yebai opened this issue Aug 19, 2021 · 2 comments · Fixed by #198
Closed

BetaPrime distribution has broken tests with the recent release of Distributions. #196

yebai opened this issue Aug 19, 2021 · 2 comments · Fixed by #198

Comments

@yebai
Copy link
Member

yebai commented Aug 19, 2021

See #185 (comment)
@devmotion
Copy link
Member

It seems the choice of parameter alpha was just unfortunate since alpha = 1 leads to the special case where xlogy ends up in the always-zero branch. Setting the parameter to 1.5, as done in the recent PRs, fixes the issue. Unfortunately, the PRs revealed many Zygote issues (somehow we end up with NamedTuple instead Tangent in some intermediate step and therefore Zygote throws an error) so the PRs can't be released currently.

@devmotion devmotion mentioned this issue Aug 31, 2021
Merged
@devmotion
Copy link
Member

More details: #198 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test errors and update to ChainRules 1 and Distributions 0.25.15 TuringLang/DistributionsAD.jl
2 participants
@devmotion @yebai