Skip to content

Commit

Permalink
remove convergence criterion for now
Browse files Browse the repository at this point in the history
  • Loading branch information
Red-Portal committed Aug 13, 2023
1 parent e66935b commit 9f1c647
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion docs/src/families.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
The [location-scale](https://en.wikipedia.org/wiki/Location%E2%80%93scale_family) variational family is a family of probability distributions, where their sampling process can be represented as
```math
z \sim q_{\lambda} \qquad\Leftrightarrow\qquad
z \stackrel{d}{=} z = C u + m;\quad u \sim \varphi
z \stackrel{d}{=} C u + m;\quad u \sim \varphi
```
where ``C`` is the *scale*, ``m`` is the location, and ``\varphi`` is the *base distribution*.
``m`` and ``C`` form the variational parameters ``\lambda = (m, C)`` of ``q_{\lambda}``.
Expand Down
7 changes: 0 additions & 7 deletions src/optimize.jl
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ function optimize(
rng ::AbstractRNG = default_rng(),
show_progress::Bool = true,
callback! = nothing,
#convergence = (args...) -> (false, con_state),
adbackend::AbstractADType = AutoForwardDiff(),
prog = ProgressMeter.Progress(
n_max_iter;
Expand All @@ -64,7 +63,6 @@ function optimize(
λ = copy(λ₀)
opt_state = Optimisers.setup(optimizer, λ)
est_state = init(objective)
#con_state = init(convergence)
grad_buf = DiffResults.GradientResult(λ)
stats = NamedTuple[]

Expand All @@ -89,11 +87,6 @@ function optimize(

pm_next!(prog, stat)
push!(stats, stat)

#convergence(rng, t, restructure, λ, q, objective, stat)
#if terminate()
# break
#end
end
λ, map(identity, stats), opt_state
end
Expand Down

0 comments on commit 9f1c647

Please sign in to comment.