Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUTS kernel options #342

Merged
merged 16 commits into from
Jul 28, 2023
Merged

NUTS kernel options #342

merged 16 commits into from
Jul 28, 2023

Conversation

JaimeRZP
Copy link
Member

Is there a reason why we are not passing the sampler options to the make_kernel function?

yebai
yebai previously approved these changes Jul 27, 2023
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I'm aware. Maybe also bump the version?

@JaimeRZP
Copy link
Member Author

Not that I'm aware. Maybe also bump the version?

bumped!

src/abstractmcmc.jl Outdated Show resolved Hide resolved
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

test/runtests.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
src/abstractmcmc.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
@JaimeRZP
Copy link
Member Author

I have also spotted an important bug in make_init_params which I have fixed and unit_tested.
However. TuringLang/Turing.jl#2050 will not run until this is merged.

@yebai yebai merged commit 3a4b384 into master Jul 28, 2023
8 of 16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nuts_kernel_opts branch July 28, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants