Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly rename rep_periods_mapping #643

Open
Tracked by #701
abelsiqueira opened this issue May 13, 2024 · 6 comments
Open
Tracked by #701

Possibly rename rep_periods_mapping #643

abelsiqueira opened this issue May 13, 2024 · 6 comments
Labels
Type: improvement Better way of doing something Zone: code architecture Changes to the structure or fundamentals

Comments

@abelsiqueira
Copy link
Member

What and Why

Since we have timeframe now, does it make sense to change the name?

Possible Drawbacks

No response

Related Issues

No response
@abelsiqueira abelsiqueira added the Type: improvement Better way of doing something label May 13, 2024
@clizbe clizbe added the Zone: code architecture Changes to the structure or fundamentals label May 13, 2024
@clizbe
Copy link
Member

clizbe commented May 13, 2024

@datejada Thoughts?

@datejada
Copy link
Member

@abelsiqueira, regarding the workflow between TulipaClustering and TulipaEnergyModel, I agree that we can have a better name to make it easy to follow. Would you happen to have any particular suggestions for the new name?

@abelsiqueira
Copy link
Member Author

At some point, I was thinking of TimeframePeriod, although by the end of this week, I might have a different opinion.

@abelsiqueira
Copy link
Member Author

Oh yeah, it is singular because of the table name refactoring that I'm working on (also affected by what happens this week) and that is being tracked in #415, the DBML.

@datejada
Copy link
Member

Ok! So, let's wait until the workflow example is finished to have a better name.

@datejada
Copy link
Member

datejada commented Jul 2, 2024

Also see comments on discussion #688

@datejada datejada mentioned this issue Aug 12, 2024
Open
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: improvement Better way of doing something Zone: code architecture Changes to the structure or fundamentals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abelsiqueira @clizbe @datejada