Skip to content

Commit 290d34f

Browse files
committed
Added {libc} to binary target name
refs #1576 - without this, we can't differentiate between glibc and musl Linux environments and Alpine download a binary linked to glibc - other projects provide prebuilt musl binaries, so I think that's wise here too - also updates README with the new target names
1 parent 57f7ee9 commit 290d34f

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@ yarn add sqlite3
3737

3838
The module uses [node-pre-gyp](https://github.com/mapbox/node-pre-gyp) to download the prebuilt binary for your platform, if it exists. These binaries are hosted on GitHub Releases for `sqlite3` versions above 5.0.2, and they are hosted on S3 otherwise. The following targets are currently provided:
3939

40-
Format: `napi-v{napi_build_version}-{platform}-{arch}`
41-
42-
* `napi-v3-darwin-x64`
43-
* `napi-v3-linux-x64`
44-
* `napi-v3-win32-ia32`
45-
* `napi-v3-win32-x64`
46-
* `napi-v6-darwin-x64`
47-
* `napi-v6-linux-x64`
48-
* `napi-v6-win32-ia32`
49-
* `napi-v6-win32-x64`
40+
Format: `napi-v{napi_build_version}-{platform}-{libc}-{arch}`
41+
42+
* `napi-v3-darwin-unknown-x64`
43+
* `napi-v3-linux-glibc-x64`
44+
* `napi-v3-win32-unknown-ia32`
45+
* `napi-v3-win32-unknown-x64`
46+
* `napi-v6-darwin-unknown-x64`
47+
* `napi-v6-linux-glibc-x64`
48+
* `napi-v6-win32-unknown-ia32`
49+
* `napi-v6-win32-unknown-x64`
5050

5151
Support for other platforms and architectures may be added in the future if CI supports building on them.
5252

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
},
1010
"binary": {
1111
"module_name": "node_sqlite3",
12-
"module_path": "./lib/binding/napi-v{napi_build_version}-{platform}-{arch}",
12+
"module_path": "./lib/binding/napi-v{napi_build_version}-{platform}-{libc}-{arch}",
1313
"host": "https://github.com/TryGhost/node-sqlite3/releases/download/",
1414
"remote_path": "v{version}",
15-
"package_name": "napi-v{napi_build_version}-{platform}-{arch}.tar.gz",
15+
"package_name": "napi-v{napi_build_version}-{platform}-{libc}-{arch}.tar.gz",
1616
"napi_versions": [
1717
3,
1818
6

0 commit comments

Comments
 (0)