Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new groupings for check results #215

Open
1 of 5 tasks
naz opened this issue Apr 12, 2019 · 0 comments
Open
1 of 5 tasks

Introduce new groupings for check results #215

naz opened this issue Apr 12, 2019 · 0 comments
Assignees

Comments

@naz
Copy link
Contributor

naz commented Apr 12, 2019

Objective

Theme fatal errors, errors, warnings, and recommendations should be grouped separately. Eventually, messages should be grouped by (1) message level and then (2) by file.

Grouping design

Fatal errors
Must be fixed to be able to activate theme.

- [file 1]
  - [fatal error 1.1]
  - [fatal error 1.2]
  - …
- [file 2]
  - [fatal error 2.1]
  - [fatal error 2.2]
  - …
- …

Errors
Highly recommended to fix, functionality could be restricted.

- [file 1]
  - [error 1.1]
  - [error 1.2]
  - …
- [file 2]
  - [error 2.1]
  - [error 2.2]
  - …
- …

Warnings

- [file 1]
  - [warning 1.1]
  - [warning 1.2]
  - …
- [file 2]
  - [warning 2.1]
  - [warning 2.2]
  - …
- …

Recommendations

- [file 1]
  - [recommendation 1.1]
  - [recommendation 1.2]
  - …
- [file 2]
  - [recommendation 2.1]
  - [recommendation 2.2]
  - …
- …

Todo:

  • fatal error/error grouping
  • investigate skipped group usage
  • add ability to group by file
  • update scoring algorithms based on new grouping
  • update gscan clients to rely on new fatal group (for example displaying them in Ghost admin report)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant