Custom routes.yaml filters ignored

[brainandbrain]

After switching to the new Source theme, the filters I've set up in my custom routes.yaml are no longer filtering posts correctly. Others in the forums also seem to have this issue: https://forum.ghost.org/t/the-source-theme-doesnt-show-posts-on-websites-with-custom-routes/41741/15

I have my routes.yaml set up to hide posts with certain tags from my homepage, which with Source no longer has any filtering. I also found that the collection pages I've set up for specific tags are only filtering up to the lazy load. The next set of posts loaded have no filtering.

EDIT: Now that I'm looking more closely, the lazy load on collection pages is loading the whole feed over again, repeating the posts already loaded.

[brainandbrain]

Narrowed down part of this issue to the feed parameter I was loading on my custom template for those pages, which was set to "index." Changing it to "archive" filtered to the correct posts on collection pages (makes sense).

I've temporarily worked around the main issue (filtering of the home post list) by manually filtering out those tags in post-list.hbs, but I wasn't able to work out why it's ignoring the custom routes.

[cathysarisky]

The problem seems to be the post-list.hbs makes a {{get}} request, instead of looping over the posts already in the route.

[cowchimp]

Anyone able to tackle this? I would be happy to offer a "bounty".

[augusto-romero-arango]

Anyone able to tackle this? I would be happy to offer a "bounty".

In post-list.hbs insted the get sections use foreach.

Look how I solved it.
SincosoftSAS@9f7a54b?diff=split&w=0

[davidfraser]

This should be solved by #72

[cowchimp]

@minimaluminium maybe you can take a look please?
this bug makes routes.yaml not work as it's documented in the default theme.

[minimaluminium]

Hello everyone,

Source offers some advanced layout options and we had to come up with some get query tricks to accomplish this. Unfortunately, the get query doesn’t respect the custom routes. We had to sacrifice the ease for those who are using custom routing with the assumption that they’re comfortable enough to edit the theme code to get it working on their end.

If you're using custom routing, we recommend modifying your theme's code directly to apply your custom routing filter to the Source theme for proper functionality.

[decathorpe]

That's really unfortunate for users of the "Starter" subscription, though - you can set custom routes, but not use Custom themes. So having this functionality be broken in the default theme out of the box means it's not usable on the "Starter" plan ...

[davidfraser]

I'm not sure why this was closed when I thought my pull request was a fairly simple, valid way of solving this in general... Was there a problem with it that I couldn't see? At minimum it would be helpful for the Source theme to document that it doesn't fully support custom routes...