Skip to content

Commit 8239315

Browse files
richard-townsend-armTrott
authored andcommitted
build: fix GetCurrentThreadStackLimits error on Windows on Arm
GetCurrentThreadStackLimits is a fairly new API, so it requires a _WIN32_WINNT value of at least 0x0602 to compile successfully. Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1 PR-URL: nodejs#33511 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 9b71f9c commit 8239315

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

tools/v8_gypfiles/v8.gyp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,8 +1036,10 @@
10361036
'<(V8_ROOT)/src/base/platform/platform-win32.cc',
10371037
'<(V8_ROOT)/src/base/win32-headers.h',
10381038
],
1039-
1040-
'defines': ['_CRT_RAND_S'], # for rand_s()
1039+
'conditions': [['target_arch == "arm64"', {
1040+
'defines': ['_WIN32_WINNT=0x0602'], # For GetCurrentThreadStackLimits on Windows on Arm
1041+
}]],
1042+
'defines': ['_CRT_RAND_S'], # for rand_s()
10411043
'direct_dependent_settings': {
10421044
'msvs_settings': {
10431045
'VCLinkerTool': {

0 commit comments

Comments
 (0)