Skip to content

Commit

Permalink
build: streamline JS test suites in Makefile
Browse files Browse the repository at this point in the history
* alphabetize the JS test suites
* Use CI_JS_SUITES variable instead of listing all tests

PR-URL: nodejs#13340
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott committed Jun 2, 2017
1 parent 1609899 commit 7b56fd8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ test: all
$(MAKE) build-addons-napi
$(MAKE) cctest
$(PYTHON) tools/test.py --mode=release -J \
doctool inspector known_issues message pseudo-tty parallel sequential \
async-hooks $(CI_NATIVE_SUITES)
$(CI_JS_SUITES) \
$(CI_NATIVE_SUITES)
$(MAKE) lint

test-parallel: all
Expand Down Expand Up @@ -328,7 +328,7 @@ test-all-valgrind: test-build
$(PYTHON) tools/test.py --mode=debug,release --valgrind

CI_NATIVE_SUITES := addons addons-napi
CI_JS_SUITES := doctool inspector known_issues message parallel pseudo-tty sequential async-hooks
CI_JS_SUITES := async-hooks doctool inspector known_issues message parallel pseudo-tty sequential

# Build and test addons without building anything else
test-ci-native: LOGLEVEL := info
Expand Down

0 comments on commit 7b56fd8

Please sign in to comment.