Skip to content

Commit

Permalink
doc: edit COLLABORATOR_GUIDE.md on closing issues
Browse files Browse the repository at this point in the history
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)

PR-URL: nodejs#24477
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott committed Nov 21, 2018
1 parent 69cc58d commit 0759b57
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,11 @@ as a _Contributor_. Ask if they have configured their git

### Closing Issues and Pull Requests

Collaborators may close any issue or pull request they believe is
not relevant for the future of the Node.js project. Where this is
unclear, the issue should be left open for several days to allow for
additional discussion. Where this does not yield input from Node.js
Collaborators or additional evidence that the issue has relevance, the
issue may be closed. Remember that issues can always be re-opened if
necessary.
Collaborators may close any issue or pull request that is not relevant to the
future of the Node.js project. Where this is unclear, leave the issue or pull
request open for several days to allow for discussion. Where this does not yield
evidence that the issue or pull request has relevance, close it. Remember that
issues and pull requests can always be re-opened if necessary.

### Author ready pull requests

Expand Down

0 comments on commit 0759b57

Please sign in to comment.