Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal #789

Open
4 of 6 tasks
andretchen0 opened this issue Jul 23, 2024 · 1 comment
Open
4 of 6 tasks

Portal #789

andretchen0 opened this issue Jul 23, 2024 · 1 comment
Assignees
Labels
feature p3-significant High-priority enhancement (priority)

Comments

@andretchen0
Copy link
Contributor

andretchen0 commented Jul 23, 2024

Description

As a developer using TresJS, I want to have a <Portal> component that can contain a separate Scene and context.

Suggested solution

Provide a <Portal> component similar to R3F.

Requirements

  • Add override-able pointer to TresContext (Also add as prop to TresCanvas: see Use window for pointerevents #581 ); use vanilla THREE.Vector2, accept Vector2 and UsePointerOptions as TresCanvas prop
  • Make these fields on TresContext swappable and (in some case injectable by the user): scene, camera, cameras, controls, raycaster, eventManager, sizes

Validations

@andretchen0 andretchen0 self-assigned this Jul 23, 2024
@andretchen0 andretchen0 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jul 23, 2024
@alvarosabu alvarosabu added p3-significant High-priority enhancement (priority) feature and removed p2-nice-to-have Not breaking anything but nice to have (priority) labels Jul 26, 2024
@alvarosabu
Copy link
Member

Hi @andretchen0 thanks for creating this feature, I'm gonna increase the feature priority since I think we should definitely have this on our roadmap

@alvarosabu alvarosabu pinned this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature p3-significant High-priority enhancement (priority)
Projects
Status: Todo
Development

No branches or pull requests

2 participants