From 5ceef7040569933b7df640db18987d42412f2132 Mon Sep 17 00:00:00 2001
From: alvarosabu <alvaro.saburido@gmail.com>
Date: Fri, 2 Jun 2023 14:54:42 +0200
Subject: [PATCH] feat: better disposal of effects

---
 src/core/effects/Bloom.vue  | 41 ++++++++++++++++++++------------
 src/core/effects/Glitch.vue | 47 +++++++++++++++++++++++--------------
 2 files changed, 55 insertions(+), 33 deletions(-)

diff --git a/src/core/effects/Bloom.vue b/src/core/effects/Bloom.vue
index f6c2220e..6994084e 100644
--- a/src/core/effects/Bloom.vue
+++ b/src/core/effects/Bloom.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { Ref, inject, ref, toRaw, unref } from 'vue'
+import { Ref, inject, onUnmounted, ref, toRaw, unref } from 'vue'
 import { BlurPass, KernelSize, EffectPass, BloomEffect, EffectComposer, BlendFunction } from 'postprocessing'
 import { useCore } from '../useCore'
 import { watch } from 'vue'
@@ -85,23 +85,28 @@ const { state } = useCore()
 
 const composer = inject<Ref<EffectComposer>>('effectComposer')
 const pass = ref<EffectPass | null>(null)
+const effect = ref<BloomEffect | null>(null)
 
-defineExpose({ pass })
+defineExpose({ pass, effect })
 
 function createPass() {
-  pass.value = new EffectPass(
-    unref(state.camera),
-    new BloomEffect({
-      blendFunction,
-      mipmapBlur,
-      intensity,
-      luminanceThreshold,
-      luminanceSmoothing,
-    }),
-  )
+  effect.value = new BloomEffect({
+    blendFunction,
+    mipmapBlur,
+    intensity,
+    luminanceThreshold,
+    luminanceSmoothing,
+  })
+  pass.value = new EffectPass(unref(state.camera), toRaw(effect.value))
 }
 
-watch(
+function disposePass() {
+  effect.value?.dispose()
+  pass.value?.dispose()
+  composer?.value.removePass(toRaw(pass.value) as EffectPass)
+}
+
+const unwatchComposer = watch(
   () => [state.camera, composer?.value],
   () => {
     if (state.camera && composer && composer.value) {
@@ -111,15 +116,21 @@ watch(
   },
 )
 
-watch(
+const unwatchProps = watch(
   () => [blendFunction, mipmapBlur, intensity, luminanceThreshold, luminanceSmoothing],
   () => {
     if (pass.value) {
-      composer?.value.removePass(toRaw(pass.value) as EffectPass)
+      disposePass()
       createPass()
       composer?.value?.addPass(toRaw(pass.value) as EffectPass)
     }
   },
 )
+
+onUnmounted(() => {
+  disposePass()
+  unwatchComposer()
+  unwatchProps()
+})
 </script>
 <template></template>
diff --git a/src/core/effects/Glitch.vue b/src/core/effects/Glitch.vue
index e119b0cc..fb81a404 100644
--- a/src/core/effects/Glitch.vue
+++ b/src/core/effects/Glitch.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import { GlitchMode, EffectComposer, EffectPass, GlitchEffect, BlendFunction } from 'postprocessing'
-import { Ref, inject, ref, toRaw, unref, watch, watchEffect } from 'vue'
+import { Ref, inject, onUnmounted, ref, toRaw, unref, watch, watchEffect } from 'vue'
 
 import { Vector2, Texture } from 'three'
 
@@ -113,26 +113,31 @@ const { state } = useCore()
 
 const composer = inject<Ref<EffectComposer>>('effectComposer')
 const pass = ref<EffectPass | null>(null)
+const effect = ref<GlitchEffect | null>(null)
 
 defineExpose({ pass })
 
 function createPass() {
-  pass.value = new EffectPass(
-    unref(state.camera),
-    new GlitchEffect({
-      blendFunction,
-      delay,
-      duration,
-      strength,
-      ratio,
-      columns,
-      chromaticAberrationOffset,
-      dtSize,
-    }),
-  )
+  effect.value = new GlitchEffect({
+    blendFunction,
+    delay,
+    duration,
+    strength,
+    ratio,
+    columns,
+    chromaticAberrationOffset,
+    dtSize,
+  })
+  pass.value = new EffectPass(unref(state.camera), toRaw(effect.value) as GlitchEffect)
 }
 
-watch(
+function disposePass() {
+  effect.value?.dispose()
+  pass.value?.dispose()
+  composer?.value.removePass(toRaw(pass.value) as EffectPass)
+}
+
+const unwatchComposer = watch(
   () => [state.camera, composer?.value],
   () => {
     if (state.camera && composer && composer.value) {
@@ -142,10 +147,9 @@ watch(
   },
 )
 
-watch(
+const unwatchProps = watch(
   () => [delay, duration, strength, ratio, columns, chromaticAberrationOffset, peturbationMap, dtSize],
   () => {
-    console.log('props changed', composer?.value.passes)
     if (pass.value) {
       composer?.value.removePass(toRaw(pass.value) as EffectPass)
       createPass()
@@ -160,7 +164,7 @@ watchEffect(() => {
   }
 })
 
-watch(
+const unwatchActive = watch(
   () => active,
   value => {
     if (pass.value) {
@@ -168,5 +172,12 @@ watch(
     }
   },
 )
+
+onUnmounted(() => {
+  disposePass()
+  unwatchComposer()
+  unwatchProps()
+  unwatchActive()
+})
 </script>
 <template></template>