Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackball Controls not extending properly #453

Open
5 tasks done
nart4hire opened this issue Jul 22, 2024 · 4 comments
Open
5 tasks done

Trackball Controls not extending properly #453

nart4hire opened this issue Jul 22, 2024 · 4 comments

Comments

@nart4hire
Copy link

Describe the bug

Follow up for this Discussion.

tl;dr: I tried extending Trackball Controls according to the documentation for extending Orbit Controls, however it didn't work. Confirmed to be a bug with Cientos, so I made this issue.

Reproduction

https://stackblitz.com/edit/tresjs-minimal-reproduction-vev5jt?file=src%2Fcomponents%2FTheExperience.vue

Steps to reproduce

Extend trackball controls like how you would with orbit controls as mentioned in the TresJS docs

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @tresjs/cientos: 3.9.0 => 3.9.0 
    @tresjs/core: 4.0.2 => 4.0.2 
    vite: ^5.3.2 => 5.3.2

Used Package Manager

pnpm

Code of Conduct

Copy link

stackblitz bot commented Jul 22, 2024

@andretchen0
Copy link
Contributor

Thanks for filing the issue @nart4hire .

@skmbr
Copy link

skmbr commented Aug 18, 2024

Hi there! I'm new to Tresjs (and Three.js!) and came across this issue as I was searching for a way to use TrackballControls in my app.

Does this issue currently make it impossible to use TrackballControls with Tresjs?

I've tried following both methods in https://docs.tresjs.org/advanced/extending.html but get errors regarding state being undefined, and am wondering if that's related to this issue before I start digging further myself?

Is it likely that TrackballControls will be part of Cientos like OrbitControls is?

@JaimeTorrealba
Copy link
Member

Hi @skmbr this will require some research, we don't know why is not working properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants