Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Htmlis still on the page ! ┭┮﹏┭┮ #431

Open
5 tasks done
hexianWeb opened this issue May 28, 2024 · 3 comments
Open
5 tasks done

Htmlis still on the page ! ┭┮﹏┭┮ #431

hexianWeb opened this issue May 28, 2024 · 3 comments

Comments

@hexianWeb
Copy link

Describe the bug

I noticed that tresjs helped me realize the dispose of resources, so I import vue-router in the Demo, hoping to use vue's life cycle components to help me switch scenes without worrying about resources not being disposed in time. But after I changed the routerView by url, the model in the scene finished changing, but the HTML still stayed on the page. I think this may due to createRenderer or nodeops dispose component and its child before the lifecycle hooks execute。

Snipaste_2024-05-28_22-11-23

Snipaste_2024-05-28_22-12-01

Reproduction

https://stackblitz.com/~/github.com/hexianWeb/tresjs-playground

Steps to reproduce

  1. click the "Go to other" button
  2. click the "Go to one“ button

System Info

No response

Used Package Manager

pnpm

Code of Conduct

@hexianWeb hexianWeb changed the title Html is still on the page ! ┭┮﹏┭┮ Html is still on the page ! ┭┮﹏┭┮ May 29, 2024
@hexianWeb hexianWeb changed the title Html is still on the page ! ┭┮﹏┭┮ Htmlis still on the page ! ┭┮﹏┭┮ May 29, 2024
@JakobHock
Copy link
Contributor

I don't see the described behavior in the stackblitz reproduction.

Has this issue been fixed?

@hexianWeb
Copy link
Author

Sorry for the late reply, this issue has been fixed after tresjs v 4.0.0.

This is the view when using tresjs v3.9.0.
Need to close this issue?

bandicam.2024-06-07.20-17-26-105.mp4

@JakobHock
Copy link
Contributor

Hmm i'm not sure..
As there was only one breaking change between 3.9 and 4.0 i think upgrading to tres 4 is not that much of an issue.

Maybe @alvarosabu can chime in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants