Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install kink via the tap on a mac m1 #20

Closed
rberrelleza opened this issue Sep 16, 2021 · 8 comments
Closed

Can't install kink via the tap on a mac m1 #20

rberrelleza opened this issue Sep 16, 2021 · 8 comments

Comments

@rberrelleza
Copy link

rberrelleza commented Sep 16, 2021

I tried installing kink using homebrew, but got the following error:

Error: Invalid formula: /opt/homebrew/Library/Taps/trendyol/homebrew-trendyol-tap/kink.rb
formulae require at least a URL
Error: Cannot tap trendyol/trendyol-tap: invalid syntax in tap!

This is on a MacM1, MacOS 11.5 and Homebrew 3.2.12

Updated issue to indicate that it's related to arm vs amd64.

@developer-guy
Copy link
Member

hello @rberrelleza, thanks for opening the issue, but I hate to say that it is working on my machine but really it is, I couldn't reproduce the same issue on my machine:
Screen Shot 2021-09-17 at 15 27 03

PTAL @Dentrax @erkanzileli

@ysicing
Copy link

ysicing commented Sep 21, 2021

@developer-guy not working in M1

==> Tapping trendyol/trendyol-tap
Cloning into '/opt/homebrew/Library/Taps/trendyol/homebrew-trendyol-tap'...
remote: Enumerating objects: 198, done.
remote: Counting objects: 100% (54/54), done.
remote: Compressing objects: 100% (47/47), done.
remote: Total 198 (delta 30), reused 15 (delta 7), pack-reused 144
Receiving objects: 100% (198/198), 37.32 KiB | 796.00 KiB/s, done.
Resolving deltas: 100% (104/104), done.
Error: Invalid formula: /opt/homebrew/Library/Taps/trendyol/homebrew-trendyol-tap/kink.rb
formulae require at least a URL
Error: Cannot tap trendyol/trendyol-tap: invalid syntax in tap!

@ysicing
Copy link

ysicing commented Sep 21, 2021

not support arm, Kink Tap needs to be updated

https://github.com/Trendyol/homebrew-trendyol-tap/blob/master/kink.rb#L13

@rberrelleza
Copy link
Author

You're right, that's the issue. I'll update the issue and the team can decide what to do.

@rberrelleza rberrelleza changed the title Can't install kink via the tap Can't install kink via the tap on a mac m1 Sep 21, 2021
@ciiiii
Copy link
Contributor

ciiiii commented Dec 22, 2021

I'm working on a m1 Mac, can I do some work for this?

@Dentrax
Copy link
Member

Dentrax commented Dec 22, 2021

I'm working on a m1 Mac, can I do some work for this?

As @ysicing said already, we have to build for arm64 in the goreleaser.yaml and update the brew tap afterward.

@ciiiii Yes! You can get to it.

@ciiiii
Copy link
Contributor

ciiiii commented Dec 22, 2021

@Dentrax I do some work about build and installation in PR #47, check that when you guys are free. 😊

@developer-guy
Copy link
Member

it should be fixed by #47, it will released with v0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants